Uh oh!
There was an error while loading. Please reload this page.
fix: Remove dep that is giving dependabot some troubles - #300
Merged
Conversation
…sis.CSharp Bumps [Microsoft.CodeAnalysis.CSharp.Workspaces](https://github.com/dotnet/roslyn) and [Microsoft.CodeAnalysis.CSharp](https://github.com/dotnet/roslyn). These dependencies needed to be updated together. Updates `Microsoft.CodeAnalysis.CSharp.Workspaces` from 4.8.0 to 4.9.2 - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) Updates `Microsoft.CodeAnalysis.CSharp` from 4.8.0 to 4.9.2 - [Release notes](https://github.com/dotnet/roslyn/releases) - [Changelog](https://github.com/dotnet/roslyn/blob/main/docs/Breaking%20API%20Changes.md) - [Commits](https://github.com/dotnet/roslyn/commits) --- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp.Workspaces dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
BenjaminMichaelisforce-pushed
the
BMichaelis/Deps
branch
from
March 27, 2024 22:32
ab6f777 to
fab53e5CompareBenjaminMichaelis added a commit
that referenced
this pull request
Feb 3, 2026
PR #300 proposed removing the redundant `Microsoft.CodeAnalysis.Workspaces.Common` dependency, which is already a transitive dependency of `Microsoft.CodeAnalysis.Workspaces.MSBuild`. The changes remain valid for the current codebase. ## Changes - **Removed redundant dependency**: `Microsoft.CodeAnalysis.Workspaces.Common` from `Directory.Packages.props` - Already pulled in transitively by `Microsoft.CodeAnalysis.Workspaces.MSBuild` - **Added `Directory.Packages.props` to solution items** for easier Visual Studio access <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Take a look at https://github.com/IntelliTect/CodingGuidelines/pull/300/changes and if it is still true and valid and if it is, make changes for our codebase as it is today. </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: BenjaminMichaelis <22186029+BenjaminMichaelis@users.noreply.github.com> Co-authored-by: Benjamin Michaelis <git@relay.benjamin.michaelis.net>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <PackageVersion Include="Microsoft.CodeAnalysis.Workspaces.MSBuild" Version="5.0.0" /> | ||
| <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" /> | ||
| <PackageVersion Include="MSTest.TestAdapter" Version="4.1.0" /> | ||
| <PackageVersion Include="MSTest.TestFramework" Version="4.1.0" /> |
There was a problem hiding this comment.
The PR title and description claim to remove the Microsoft.CodeAnalysis.Workspaces.Common dependency to resolve Dependabot issues. However, the actual change in this PR is updating MSTest.TestFramework from version 4.1.0 to 4.1.4. There is no removal of Microsoft.CodeAnalysis.Workspaces.Common in this diff, and searching the codebase shows no existing references to this package. Either the PR description is incorrect, or the intended changes were not included in this PR.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft.CodeAnalysis.Workspaces.Commonis a dep ofMicrosoft.CodeAnalysis.Workspaces.MSBuild. Is there any advantage to having it directly? Can we just remove the direct reference? Thoughts?