proposal: a create-from is guarded by the source's status - #64
Open
delchev wants to merge 1 commit into
Open
Conversation
A generates create-from runs whenever it is invoked, as often as it is invoked - so a sourceStatus completion hook flips the source and the button goes on being offered on the flipped record, minting a second document from a source that can produce only one. Proposes fromStatus: on a create-from (the transitions from:, spelled differently because from: already names the source entity), and derives the implied guard from a declared sourceStatus so an existing model is corrected without an authoring change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
0032-create-from-guarded-by-source-status.md. Implementation: eclipse-dirigible/dirigible#7068.A
generatescreate-from runs whenever it is invoked, as often as it is invoked. That is right for an action a user may repeat and wrong for the flow the construct exists for - minting a follow-up document from a source that can only produce one. AsourceStatuscompletion hook flips the source once the target exists, and the button goes on being offered on the flipped record: a second invoice for the same proforma, to the same customer, with nothing failing.The hook already declares what "already done" looks like. Nothing consults it.
Proposes
fromStatus:- the source statuses the action may run from - which is thefrom:of atransitionsentry, spelled differently only becausefrom:on a create-from already names the source entity. A create-from declaringsourceStatusand nofromStatusis guarded against exactly that status, so a model carrying this today is corrected without an authoring change.Carries
Specification text,AnchorandDSL indexsections for the fold.