proposal: a count tile over an aggregating report - #67
Open
delchev wants to merge 1 commit into
Open
Conversation
`kind: count` is specified as "the number of records the report yields", which on a report declaring measures is not the number of rows in its result set - those are groups. Specify the count as the report's `count(*)` measure summed over the rows, and reject an aggregating report that declares no such measure rather than let a generator show the number of groups. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
widget: { kind: count }is specified as "the number of records the report yields". A report that declaresmeasures:yields one row per group, so a generator that counts result rows shows the number of GROUPS - a report dimensioned by status reads 4 next to a list of 14 records, which looks like a filter rather than a defect.The proposal adds no key: the count of an aggregating report is its
count(*)measure summed over the rows (under the same filter, scope, parameters and widget pins), an un-aggregated report keeps the row count, and an aggregating report carrying a count tile with nocount(*)measure is rejected at generation instead of showing the group count. A ledger balance / statement, whose rows are its unit of account, is exempt.Implemented in eclipse-dirigible/dirigible#7113; reported as eclipse-dirigible/dirigible#7102.
🤖 Generated with Claude Code