proposal: a value required only under a condition - #70
Open
delchev wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal
0036.required: truesays a value must always be there; most business rules about a missing value are not like that - the value is needed for ONE way of handling the record and meaningless for the others. An invoice sent by e-mail needs the customer's e-mail address, one sent by post does not, and one handed over needs neither, sorequiredon the address would refuse every customer who is never e-mailed.checks:hasexactlyOne,itemsSumEqualanditemsMin, none of which say it either - so nothing says it, and an e-mailed invoice whose customer carries no address reaches "sent" with nobody to send it to.The proposed
requiredWhennames the value (a field, or a one-hopRelation.field), the condition it is required under, and optionally the status at which the condition is evaluated - the last being what makes the rule expressible at all, since a record still being typed has not chosen how it will be sent.Also covered: why an uninterpretable condition has to be a validation error in both directions, why the condition's operands are restricted to the types an equality is exact on, and the two hand-written workarounds the shape replaces (a step before the sending action - about fifteen declarative lines plus a class for one sentence of rule, landing the user on a hold task instead of a refusal - and a step after it, whose refusal has nowhere to go).
Implemented in Eclipse Dirigible: eclipse-dirigible/dirigible#7129 (issue eclipse-dirigible/dirigible#7094).
🤖 Generated with Claude Code