proposal: which source rows become lines - #72
Open
delchev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A create-from's mirror
items:block clones EVERY row of the source document into a target line, and there is no way to say which rows qualify. So an invoice generated from a project month bills every member timesheet it holds — a DRAFT or REJECTED one at the same footing as an APPROVED one, and one with no hours at all is a line the target refuses outright, so a single unfinished row stops the whole month from being invoiced.The proposal adds
where:(the rule that selects the qualifying rows, in the shape a scheduled query already uses) andrefuse:(the reading where an unqualified row stops the generation with an authored message naming the rows, instead of being left out of the document). A rule that qualifies no row refuses either way, rather than committing a document with no lines.proposals/0037-which-source-rows-become-lines.md. Reference implementation: eclipse-dirigible/dirigible#7164 (issue eclipse-dirigible/dirigible#7091). Site page: IntentFile/intentfile.github.io#51.