Skip to content

Remove xrate/xincrease/xdelta - #31

Open
ColinDKelley wants to merge 3 commits into
invoca-3.13/port-rate-funcsfrom
invoca-3.13/drop-xrate
Open

Remove xrate/xincrease/xdelta#31
ColinDKelley wants to merge 3 commits into
invoca-3.13/port-rate-funcsfrom
invoca-3.13/drop-xrate

Conversation

@ColinDKelley

Copy link
Copy Markdown

Summary

  • Delete the xrate/xincrease/xdelta implementation and parser registrations.
  • Drop REPLACE_RATE_FUNCS modes 1/x/X; keep only 2/y/Y for the yrate family.
  • Strip x* coverage from promqltest / replace-rate tests.

Test plan

  • go test ./promql/...
  • Confirm no deploy still sets REPLACE_RATE_FUNCS=1 or x

Made with Cursor

@ColinDKelley
ColinDKelleyforce-pushed the invoca-3.13/drop-xrate branch 2 times, most recently from 4d25173 to f0889a6CompareJuly 11, 2026 20:53
ColinDKelleyand others added 3 commits July 13, 2026 22:04
Keep only the yrate family and REPLACE_RATE_FUNCS=2/y/Y for swapping
standard rate/increase/delta.
Co-authored-by: Cursor <cursoragent@cursor.com>
make check-generated-promql-functions requires functionSignatures.ts to
match parser.Functions after dropping xrate.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@ColinDKelley
ColinDKelleyforce-pushed the invoca-3.13/port-rate-funcs branch from c461ddb to 2f743dcCompareJuly 14, 2026 05:04
@ColinDKelley
ColinDKelleyforce-pushed the invoca-3.13/drop-xrate branch from f0889a6 to 9899175CompareJuly 14, 2026 05:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ColinDKelley@ttstarck