Skip to content

Remove pyproject_old.toml - #65

Merged
xhan97 merged 1 commit into
mainfrom
chore/remove-pyproject-old
Aug 15, 2026
Merged

Remove pyproject_old.toml#65
xhan97 merged 1 commit into
mainfrom
chore/remove-pyproject-old

Conversation

@xhan97

Copy link
Copy Markdown
Collaborator

A backup of the poetry configuration, kept when the project moved to uv in 340b54c ("uv env and format", 2025-11-15).

It is redundant

The file is byte-identical to 340b54c^:pyproject.toml:

$ git show 340b54c^:pyproject.toml > /tmp/before.toml
$ diff /tmp/before.toml pyproject_old.toml &&echo identicalidentical

Git already holds a complete copy. Recovering it is git show 340b54c^:pyproject.toml. The working-tree duplicate adds nothing.

It is also actively misleading

It surfaces in searches for dependencies and configuration, next to the live file. That is not hypothetical — while tracking down why the docs build broke under notebook 7 (#44), grepping for jupyter-contrib-nbextensions hit pyproject_old.toml:115 as well as the real pin, and the stale entry had to be ruled out before the actual cause was clear. Anyone grepping this repo for a dependency gets a nine-month-old snapshot mixed into the results.

Verification

Nothing in the repo references it. uv build produces the expected wheel and sdist, ruff check is clean, and uv lock --check is consistent. A sweep for other leftovers of this kind (*_old, *.bak, *.orig, *copy*, *backup*) found none.

A backup of the poetry configuration, kept when the project moved to uv
in 340b54c (2025-11-15). It is byte-identical to 340b54c^:pyproject.toml,
so git already holds a complete copy and the working-tree duplicate adds
no recoverability.
It does add noise. Searches for dependencies or configuration hit a
nine-month-old snapshot alongside the live file -- the stale
jupyter-contrib-nbextensions pin in it turned up while tracking down an
unrelated docs failure, and had to be ruled out before the real cause was
clear.
Nothing references the file; the build, lint, and lock checks are
unaffected.
@xhan97
xhan97 merged commit 9003e40 into mainAug 15, 2026
16 checks passed
@xhan97
xhan97 deleted the chore/remove-pyproject-old branch August 15, 2026 17:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@xhan97