Skip to content

fix(crypto/shared): mul_tables.s stub size .res 256 -> .res 512#46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JC-000 merged 1 commit into from
May 21, 2026
Merged

fix(crypto/shared): mul_tables.s stub size .res 256 -> .res 512 #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/crypto/shared/mul_tables.s
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,9 +15,18 @@
; Public API:
; mul_tables_init - build the 256x256 quarter-square tables
; (currently: stub; returns immediately).
; sqtab_lo, sqtab_hi - 256-byte tables, page-aligned, in TABLES_BSS
; sqtab_lo, sqtab_hi - 512-byte tables each (1 KB total), page-aligned,
; in TABLES_BSS. Layout `sqtab_hi = sqtab_lo + $0200`;
; semantics `(sqtab_hi[n] << 8) | sqtab_lo[n] =
; floor(n^2 / 4)` for n in 0..510.
; (currently: defined by src/data.s; re-homed here
; under CANONICAL_SQTAB in a later phase).
; under CANONICAL_SQTAB in a later phase.)
;
; Size note: each table is 512 bytes, not 256. The earlier stub used
; `.res 256` which would silently truncate at n >= 256 once any sibling
; lib redirected its init here — every in-the-wild implementation uses
; 512 B per table (see `src/data.s:136` here, and the audit in
; `c64-lib-contract` issue #5). Fixed before any redirect lands.
; =============================================================================

.export mul_tables_init
Expand All@@ -41,6 +50,6 @@ mul_tables_init:
.export sqtab_hi

.segment "TABLES_BSS"
sqtab_lo: .res 256
sqtab_hi: .res 256
sqtab_lo: .res 512
sqtab_hi: .res 512
.endif