Skip to content

Fixtest - #86

Closed
MrBartWolf wants to merge 9 commits into
JMU-CS:masterfrom
MrBartWolf:fixtest
Closed

Fixtest#86
MrBartWolf wants to merge 9 commits into
JMU-CS:masterfrom
MrBartWolf:fixtest

Conversation

@MrBartWolf

Copy link
Copy Markdown
Contributor

Fixed the failing test and moved it out of the failing directory. This request should be merged after the one that changes dotests.sh

@lam2mo

Copy link
Copy Markdown
Member

This should definitely be squashed or cleaned up before merging--there's a lot of clutter in the git history.

@MrBartWolf

Copy link
Copy Markdown
ContributorAuthor

I'm trying to figure out how to clean up the commit history, that's new for me.

@lam2mo

Copy link
Copy Markdown
Member

No worries. We'll probably just squash the commits when we merge the pull request. However, this branch is now in conflict so we may also decide it's easier to just cancel this pull request and make the change fresh once we clear up all the other testing-related pull requests.

@lam2mo

Copy link
Copy Markdown
Member

DO NOT MERGE.

These changes will be added to #79 and then this pull request will be closed.

@lam2mo

Copy link
Copy Markdown
Member

This PR is obsolete and replaced by changes in #79.

@lam2molam2mo closed this Feb 26, 2020
@MrBartWolf
MrBartWolf deleted the fixtest branch February 26, 2020 17:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@MrBartWolf@lam2mo