Skip to content

Fixing R CMD CHECK and re-adding biocparallel - #32

Merged
eboyer221 merged 3 commits into
mainfrom
fix-cmd
Aug 12, 2026
Merged

Fixing R CMD CHECK and re-adding biocparallel#32
eboyer221 merged 3 commits into
mainfrom
fix-cmd

Conversation

@amcim

Copy link
Copy Markdown
Contributor

This PR has the purpose of getting R CMD CHECK working again and re-adding essential Bioconductor requirements (BiocParallel).

The main problem with R CMD CHECK was malformed roxygen blocks, mostly in generate_matrices_ml.R. devtools::document() was erroring out partway through, so the .Rd files never regenerated, and that stale documentation is what produced most of the issues. Fixing the roxygen resolved those as a side effect. Additionally some parameters for functions across the package were out of date and were updated.

BiocParallel had been swapped out for future/future.apply. Restored SnowParam(RNGseed = seed) + bplapply(), matching #23.

@eboyer221eboyer221 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed that this restores BiocParallel::SnowParam()/bplapply() in runMDRmodels()/runMLmodels() (matching #23) and fixes the malformed roxygen blocks that were breaking devtools::document(). No issues in the lines this PR touches.

@eboyer221eboyer221 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this does what it says: restores BiocParallel::SnowParam()/bplapply() in runMDRmodels()/runMLmodels() (matching #23) and fixes the malformed roxygen blocks that were breaking devtools::document(). Diff is clean and narrowly scoped — no issues in the lines this PR actually touches.

(Found some pre-existing bugs elsewhere in the codebase while reviewing — unrelated to this PR, will file separately.)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@amcim@eboyer221