Uh oh!
There was an error while loading. Please reload this page.
- Enhancement: jsdoc/typescript type for better clarity and specificty - #115
- Enhancement: jsdoc/typescript type for better clarity and specificty#115brettz9 wants to merge 6 commits into
Conversation
04cdac0 to
f4d1be4Compare
kf6kjg
left a comment
There was a problem hiding this comment.
In general I'm against the use of the any type in TypeScript. If you don't know the type then unknown is a better fit as it forces the user to determine the type. The any type simply bypasses all the type features of TypeScript.
That said, in any of my comments where I suggest code changes and I use the unknown type, I'm perfectly OK with you using the any type instead: it's your library.
Other than those bits of being informative, I like the change and it's a definite improvement.
| * expressions; see the Syntax section for details.) | ||
| */ | ||
| sandbox?: Map<string, any> | ||
| sandbox?: { [key: string]: any } |
There was a problem hiding this comment.
While valid, there's also the following types that may express your intent better, or not:
{ [key: PropertyKey]: unknown }Record<string, unknown>Record<PropertyKey, unknown>- this one's my preference.
Ditto for the other places where you use an index notation.
No description provided.