Uh oh!
There was an error while loading. Please reload this page.
Using SDK Version variables from root project - #6
Open
rayronvictor wants to merge 2 commits into
Open
Conversation
Instead of assuming the `compileSdkVersion`, `targetSdkVersion`, etc, read it from the root project. Default `compileSdkVersion` and `targetSdkVersion` to the latest versions. Android Target API Level 26 will be required in August 2018. https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html And the React Native team is already working on this: react/react-native#17741react/react-native#18095
jaimecbernardo
self-requested a review
April 24, 2018 15:07
jaimecbernardo
commented
May 2, 2018
Member
Hi @rayronvictor, The behavior is as if the |
jaimecbernardo
commented
Jul 26, 2018
Member
A recent released change in React-Native relates to this PR. Newly created project-wise definitions seem to be what this PR's changes refer to. |
staltz
commented
Oct 26, 2021
Contributor
We're maintaining this module now as a fork at https://github.com/nodejs-mobile/nodejs-mobile-react-native |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of assuming the
compileSdkVersion,targetSdkVersion, etc, read it from the root project.Default
compileSdkVersionandtargetSdkVersionto the latest versions.Android Target API Level 26 will be required in August 2018.
https://android-developers.googleblog.com/2017/12/improving-app-security-and-performance.html
And the React Native team is already working on this:
react/react-native#17741
react/react-native#18095