Uh oh!
There was an error while loading. Please reload this page.
Add search and dropdown menu with book categories - #58
Open
YuriiHaidamaka wants to merge 160 commits into
Open
Conversation
# Conflicts: # client-web/src/exlibris-app/exlibris-app.html
# Conflicts: # client-web/src/exlibris-app/exlibris-app.html
# Conflicts: # client-web/src/exlibris-app/exlibris-app.html # client-web/src/exlibris-app/shell/redux-store.html
# Conflicts: # client-web/src/exlibris-app/exlibris-app.html
# Conflicts: # client-web/bower.json # client-web/src/exlibris-app/exlibris-app.html
Codecov Report
@@ Coverage Diff @@## master #58 +/- ##
==========================================
+ Coverage 96.16% 96.99% +0.83%
==========================================
Files 11 39 +28 Lines 860 1966 +1106 Branches 41 56 +15 ==========================================
+ Hits 827 1907 +1080 - Misses 23 42 +19 - Partials 10 17 +7 |
# Conflicts: # client-web/src/exlibris-app/reducers/exlibris-reducer.html
YuriiHaidamakaforce-pushed
the
add_search_and_dropdown
branch
from
April 16, 2018 16:00
43d09d6 to
6cf875aCompare# Conflicts: # client-web/src/exlibris-app/book/book-values.html # client-web/src/exlibris-app/book/exlibris-book-grid.html # client-web/src/exlibris-app/book/exlibris-book-tile.html # client-web/src/exlibris-app/exlibris-app.html # client-web/src/exlibris-app/reducers/exlibris-reducer.html # client-web/test/exlibris-app/exlibris-app_store_test.html
# Conflicts: # client-web/src/exlibris-app/actions/exlibris-actions.html # client-web/src/exlibris-app/book/book-values.html # client-web/src/exlibris-app/book/exlibris-book-grid.html # client-web/src/exlibris-app/book/exlibris-book-tile.html # client-web/src/exlibris-app/exlibris-app.html # client-web/src/exlibris-app/reducers/exlibris-reducer.html
# Conflicts: # client-web/src/exlibris-app/book/book-values.html # client-web/src/exlibris-app/book/exlibris-book-grid.html # client-web/src/exlibris-app/book/exlibris-book-tile.html # client-web/src/exlibris-app/exlibris-app.html # client-web/src/exlibris-app/reducers/exlibris-reducer.html # client-web/test/exlibris-app/exlibris-app_store_test.html
YuriiHaidamakaforce-pushed
the
add_search_and_dropdown
branch
from
May 3, 2018 13:48
62de68b to
fab8e4eCompare# Conflicts: # client-web/src/exlibris-app/actions/exlibris-action.html # client-web/src/exlibris-app/actions/exlibris-actions.html # client-web/src/exlibris-app/book/book-values.html # client-web/src/exlibris-app/book/exlibris-book-grid.html # client-web/src/exlibris-app/book/exlibris-book-tile.html # client-web/src/exlibris-app/exlibris-app.html # client-web/src/exlibris-app/reducers/exlibris-reducer.html # client-web/test/exlibris-app/exlibris-app_store_test.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we have created
<exlibris-category-dropdown>and<exlibris-book-search>web components according to next user tasks:-Add category drop-down selector for
All Booksitem-Add search input to the
<app-header>The
<exlibris-category-dropdown>shows a dropdown menu with categories.The
<exlibris-category-dropdown>works on the following URL :/#/all-books/category/{categoryName}Each item from dropdown menu is a link of the next format:
/#/all-books/category/{categoryName}. This link will show all books from the library from this category. After clicking on theAll Booksmenu item the filtering is canceled and<exlibris-category-dropdown>is reseted.The
<exlibris-category-dropdown>should only be shown forAll Books. In the web componentexlibris-book-gridwas addedslotfor this purpose.The
<exlibris-book-search>allows to searchallBooksarray.The
<exlibris-book-search>works on the following URL :/?q={query}#/all-books.After 500 milliseconds as the query was changed the
exlibris-book-search-query-changedwill be fired and the corresponding action will be dispatch to the redux store.Page with all books has the next design now :
With open
<exlibris-category-dropdown>:Result of emty search:
The result of the
polymer lint: