Uh oh!
There was an error while loading. Please reload this page.
add setting and getting config in json format - #540
Conversation
danthe1st
left a comment
There was a problem hiding this comment.
I have yet to test this but here's my initial review.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The changes look good to me and testing (including with native-image) seems like this mostly works.
However, I noticed one small regression due to how you removed the property parsers: When I try to set a string, it requires a double quotes around it. This breaks things like /config set property:moderationConfig.banMessageText value:Hello 123. I added a suggestion of how that could probably be fixed but that doesn't mean you have to do it that way.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
changes
/config get displays the object in json format
/config set displays the object in json format and accepts json format
removed old way of displaying objects
gson registered as a bean
very amazing pr