Uh oh!
There was an error while loading. Please reload this page.
Add support for distinct queries in Query class - #59
Open
x7airworker wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds DISTINCT support to the ORM Query API and MySQL query renderer so consumers can request de-duplicated results.
Changes:
- Introduces
distinct/distinctColumnstate and fluentdistinct(...)methods onQuery. - Updates
MySQLQueryStringRendererto emitSELECT DISTINCT ...based on the newQueryflags.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/org/javawebstack/orm/renderer/MySQLQueryStringRenderer.java | Adds DISTINCT handling when rendering SELECT queries. |
| src/main/java/org/javawebstack/orm/query/Query.java | Adds DISTINCT configuration to the query builder API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| Repo<?> repo = query.getRepo(); | ||
| List<Object> parameters = new ArrayList<>(); | ||
| StringBuilder sb = new StringBuilder("SELECT "); | ||
| if (query.isDistinct()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.