Skip to content

refactor(rendering): retire legacy SkyboxPass - #827

Merged
JeanPhilippeKernel merged 1 commit into
developfrom
task/retire-legacy-skybox-pass
Sep 17, 2026
Merged

JeanPhilippeKernel merged 1 commit into
developfrom
task/retire-legacy-skybox-pass

Conversation

@JeanPhilippeKernel

Copy link
Copy Markdown
Owner

Closes #809

Summary

  • Replace the legacy SkyboxPass and skybox shaders with EnvironmentBackgroundPass.
  • Preserve HDRI and fixed fallback presentation while using the camera far depth for reverse-Z.
  • Remove obsolete references, refresh architecture docs, and add focused coverage.

Validation

  • Debug: ZEngineTests full suite (four existing Vulkan-dependent skips)
  • Debug: 42 focused sky/environment tests
  • Release: ZEngineTests and Obelisk build; 42 focused sky/environment tests
  • Obelisk Debug shader package builds with environment_background shaders
  • Repository search confirms no SkyboxPass/skybox references remain

@JeanPhilippeKernel JeanPhilippeKernel added area-rendering area-linux Work on Linux system area-window Work on Window system area-macOS Work on macOS system labels Sep 17, 2026
@JeanPhilippeKernel JeanPhilippeKernel added enhancement New feature or request vulkan-api labels Sep 17, 2026
@JeanPhilippeKernel JeanPhilippeKernel self-assigned this Sep 17, 2026
@JeanPhilippeKernel
JeanPhilippeKernel merged commit b9eb954 into develop Sep 17, 2026
17 checks passed
@JeanPhilippeKernel
JeanPhilippeKernel deleted the task/retire-legacy-skybox-pass branch September 17, 2026 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-linux Work on Linux system area-macOS Work on macOS system area-rendering area-window Work on Window system enhancement New feature or request vulkan-api

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Task] Retire legacy SkyboxPass after sky parity

1 participant