Hide create option after closing menu - #1306
Merged
Merged
Conversation
coveralls
commented
Oct 15, 2016
JedWatson
commented
Oct 15, 2016
Owner
This looks good to me, @bvaughn let me know if you can see any issues merging this? |
bvaughn
commented
Oct 15, 2016
Collaborator
Nice fix, @andreme. 😄 At a quick glance, the change seems good to me @JedWatson. Cannot easily smoke-test it b'c I am without a laptop this weekend (in between jobs) but I think the approach looks solid. |
coveralls
commented
Oct 15, 2016
andreme
commented
Nov 26, 2016
ContributorAuthor
@JedWatson@bvaughn Any chance for a merge soon? |
Praiodan
commented
Dec 12, 2016
Would be a useful fix for us, too. |
xthiago
commented
May 24, 2017
@JedWatson@bvaughn Could you merge this PR? |
g3ortega
commented
Jun 23, 2017
I'm needing this, any news? |
agirton
commented
Jun 23, 2017
Collaborator
Tested this locally and works as expected. Thank you for your patience! |
xthiago
commented
Jun 26, 2017
CShigaki
commented
Jun 28, 2017
agirton
commented
Jun 28, 2017
Collaborator
@CShigaki did you build the examples or just clone and run install? |
ryanabooth pushed a commit
to entelo/react-select
that referenced
this pull request
Jun 29, 2017
…ate_and_add_creatable_options * commit '26169305a721ec3099a912cea2f6ed38e6dc9c4c': (36 commits) Fix Usage Docs Example (JedWatson#1799) Hide create option after closing menu (JedWatson#1306) Update README.md to include 'valueComponent' prop (JedWatson#1803) Adding merged changes to changelog Fix backspace handling for non-multi select controls. FixesJedWatson#638 (JedWatson#773) Update Select.js [ADD] Clarified the onInputChange prop signature in the docs (JedWatson#1773) [FIX] JedWatson#1651 moved option prop sync to componentWillReceiveProps (JedWatson#1765) v1.0.0-rc.5 Updating build Update changelog Fix selected option focus when valueKey is not "value" (JedWatson#1733) Fix aria owns value (JedWatson#1556) FixJedWatson#1394 (JedWatson#1395) v1.0.0-rc.4 Bumping create-react-class and prop-types Update react-input-autosize dep added variables for shadow styles Move over examples to use new pkgs Migrate rest of src overto createClass pkg ... # Conflicts: # dist/react-select.js # dist/react-select.min.js # examples/dist/bundle.js # examples/dist/standalone.js # lib/Async.js # lib/Value.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always pass changes to the input value back to the Creatable.
There is one change in focusAdjacentOption where I wasn't sure whether handleInputValueChange should also be called?
This should fix#1256