Support setting options after value thru props - #79
Conversation
JedWatson
commented
Mar 9, 2015
@farism can you explain this a bit please? looks like some important logic (e.g. |
farism
commented
Mar 9, 2015
From my understanding, that line of code is purely an optimization technique? The issue is that if options are set after value, then the component will not be properly updated (and label placeholder does not change). See #74 It's hard to tell without tests, but I don't believe the code is harmful. I don't think there is an issue with calling |
farism
commented
Mar 10, 2015
Just realized that #53 pretty much addresses the same issue :) |
dcousens
commented
May 7, 2015
Please rebase. Happy to merge this or #53 |
Reggino
commented
Jul 20, 2015
I'm running into the same issue here. The fix looks good, thanks! |
No description provided.