feat(Option): support addition className - #853
Closed
iam4x wants to merge 1 commit into
Closed
Conversation
iam4xforce-pushed
the
option-additional-class
branch
from
March 30, 2016 12:59
b144973 to
6df918cComparecoveralls
commented
Mar 30, 2016
Changes Unknown when pulling 6df918c on iam4x:option-additional-class into * on JedWatson:master*. |
coveralls
commented
Mar 30, 2016
Changes Unknown when pulling 6df918c on iam4x:option-additional-class into * on JedWatson:master*. |
JedWatson added a commit
that referenced
this pull request
Apr 2, 2016
JedWatson
commented
Apr 2, 2016
Owner
Hi @iam4x, thanks for the PR! I've just manually merged it due to conflicts, sorry about not merging directly - it looks like I missed a step in the process, but the changes are now in |
iam4x
commented
Apr 4, 2016
ContributorAuthor
Thank's @JedWatson 👍 |
This was referenced May 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @JedWatson
I'm using https://github.com/ftlabs/fastclick to remove the 300ms click delay on iOS devices, but I'm getting incompatibilities with
react-selectwhich is listening ontouchEndevent.Fastclick can ignore certain elements but they need a
needsclickclass (https://github.com/ftlabs/fastclick#ignore-certain-elements-with-needsclick)This PR adds the support to pass custom classnames to the Option element, I could have used the
optionComponentprop but I find it overkill for this use case 👍