Skip to content

feat: cleanup swim wrapper - #1033

Draft
baltzell wants to merge 27 commits into
developmentfrom
swim-baltzell
Draft

feat: cleanup swim wrapper#1033
baltzell wants to merge 27 commits into
developmentfrom
swim-baltzell

Conversation

@baltzell

@baltzellbaltzell commented Dec 23, 2025

Copy link
Copy Markdown
Collaborator

In preparation for new swimming versions, do a little reorganization of org.jlab.clas.swimtools:

  • Add ISwim interface of appropriate methods from Swim
  • Add abstract ASwim for shared data and generic wrapping of some simple geometry calls
  • Refactor Swim, now extends ASwim
    • Move stoppers to a new, separate class Stoppers
    • Move parameter setup to a new, separate class SwimPars
    • Move existing "new" adaptive methods, previously unused, to AdaptiveSwim
    • Remove some unused methods
  • Add AdaptiveSwim with specific methods from Swim
  • General cleanup

TODO: remove stuff from ISwim, add wrappers to ASwim.

Note, Swim's interface and functionality is unchanged.

@baltzell
baltzell marked this pull request as ready for review December 23, 2025 22:59
@baltzell
baltzellforce-pushed the swim-baltzell branch 2 times, most recently from 9e8f239 to aef9bc2CompareJanuary 6, 2026 00:33
@baltzell
baltzell enabled auto-merge (squash) January 6, 2026 01:48
@baltzell
baltzellforce-pushed the swim-baltzell branch 3 times, most recently from 28d28ff to f6f7ff1CompareJanuary 7, 2026 04:20
@baltzellbaltzell changed the title Cleanup swim wrapperfeat/fix: cleanup swim wrapperJan 15, 2026
@baltzellbaltzell changed the title feat/fix: cleanup swim wrapperfeat: cleanup swim wrapperJan 15, 2026
@baltzell
baltzell marked this pull request as draft February 7, 2026 02:21
auto-merge was automatically disabled February 7, 2026 02:21

Pull request was converted to draft

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@baltzell