Uh oh!
There was an error while loading. Please reload this page.
Iss153 cvt straight trk angle - #351
Merged
Merged
Conversation
…ectory was using the helix method to compute the position at the cylinder radius and it was not accounting for the beam spot. Actually this computation was not needed because the KF already reports the trajectory. Both these issues have been fixed. The hemisphere was wrong in the making of the surfaces, as it took the middle of the cluster strip which for BMT C gives the wrong hemisphere for events in a particular phi range. This has been fixed by using the afore mentioned method to get the point from the seed and get the hemisphere from there.
raffaelladevita
requested changes
Nov 1, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
raffaelladevita
self-requested a review
November 5, 2024 16:01
raffaelladevita
approved these changes
Nov 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for straight tracks validated: https://clasweb.jlab.org/wiki/images/7/76/20241023-cvtstraighttrack.pdf