feat: pre-commit hook to update banks README by c-dilks · Pull Request #505 · JeffersonLab/coatjava

c-dilks · 2025-03-24T15:21:47Z

Adds a pre-commit hook to update etc/bankdefs/hipo4/README.md automatically.

Most developers do not have pre-commit installed, so the pre-commit.ci bot will do the following on a PR:

run the hook to update that README.md file
if the README.md file is changed, which happens when any of the bankdefs JSON files are updated, the bot will push a commit with the updated version

This commit should not conflict with a PR author's work, but they will need to pull or merge with the remote, since pre-commit.ci committed to their remote branch.

For those who have pre-commit installed, as well as the hook, your commit will trigger the hook; the pre-commit.ci bot will run the hook for those who don't (and for those who do, just to be sure).

We can use pre-commit hooks for other things, like auto-formatting code. In this case we have a file under version control (etc/bankdefs/hipo4/README.md) which is generated by a script, and it had fallen out of date; the pre-commit hook will make sure the file is kept up date.

Also, I added a small note about Iguana claiming group 30000, respecting JeffersonLab/iguana#306. I don't want to link to Iguana, since I'm considering migrating it to code.jlab.org.

c-dilks · 2025-03-24T15:51:59Z

confirmed the hook works in my fork:

https://results.pre-commit.ci/run/github/835782666/1742831379.nnvvz_JnQBasuVUE6GhaTg (which failed correctly, in order to trigger the pre-commit bot to update the README)
c-dilks@88482dd (the resulting update from the pre-commit bot)

Now I just need @baltzell (or someone with similar-level permissions) to either

find my request to allow pre-commit.ci to work with this repo
or configure pre-commit.ci themself (sign in to https://pre-commit.ci/ with GitHub, add JeffersonLab/coatjava repo)

Once pre-commit.ci is enabled here, I'll re-trigger the CI on this PR, which should trigger the pre-commit.ci bot to update the README.md (if not, I'll open a followup PR to do this).

baltzell · 2025-03-25T18:01:37Z

any reason not to un-draft and merge?

c-dilks · 2025-03-26T21:53:13Z

any reason not to un-draft and merge?

pre-commit-ci bot should have pushed a commit here automatically, but for that to happen, I need someone with power to click a button (probably you); I'll show you what to do next time we meet in person

c-dilks · 2025-03-26T21:55:57Z

yipe, I guess you may have clicked it already since #507 is (surprisingly) blocked

for more information, see https://pre-commit.ci

c-dilks · 2025-03-26T21:59:07Z

Good bot, now it works! This is ready now.

* DC v2: includes TFLight fix and new dc beta time walk with constants from /calibration/dc/v2 (#494) * fix issue for path length in FD tracking * fix issue for coordinate transformation from global to tilted sector coordinate * add comments to explain transition of starting point for path length * T2D with beta dependence. Fixes in interpolation. * Fix for instances where the t2d function turns over. * Fix in last interpolation step. More validation plots. * Fix table filling * B-field interpolation test interpolation in B instead of B^2. More plots * Added modularity for calibration use * version bump * switch to use new dc/v2 tables * switch to use new dc/v2 for ref_pressure too --------- Co-authored-by: tongtongcao <tongtongcao1@gmail.com> Co-authored-by: ziegler <ziegler@enpziegler-mac> * Update DC reconstruction at the denoisinng level (#499) * cancel SNR and change limit of total DC hits from raw hits to hits after denoising * remove unused codes * reset limit for prob in DC clustering and cancel requirement that no skipped layer for cluster candidates from splitter (#500) * pass 2 additional values * fix data type * feat: pre-commit hook to update banks README (#505) * Change the option to select the track finding to a enum. Now this option can be setup from the yaml file with the option Mode: ``` ALERT: Mode: "AI_Track_Finding" ``` Add a cut on the number of hits to rely on the conventional track finding with there is more than 300 hits. * Change the default options for DJL: - Use a single thread for the inference. - Remove waring about the graph executor optimization * Modification of the track candidates generation * Improve the function to get all the track candidates. * Update AHDCEngine to initialize model conditionally and adjust prediction threshold * New features for ALERT Kalman filter+optimized parameters (#445) * Optimization of Kalman Filter: * adjusted number of filtering iterations from 10 to 5; * adjusted step size dx for calculation of ddoca/dx from 10^8 to 10^5; * Added AHDC hits residuals (post-fit and pre-fit) in the output: * residuals in the AHDC::Hits list in the alert.json file; * filling the hits residuals in the RecoBankWriter; * added residual and residual_prefit in ahdc/Hit/Hit.java * added a identification flag to match ahdc/KalmanFilter/Hit.java to ahdc/Hit/Hit.java * Successfully affected the calculated hit residual to the correct AHDC::Hit. * Fixed and improved the calculation of the post-fit residuals: * affecting the track parameters to the KFTrack right after the fit; * redo a forward indicators pass without correction; * * Cleaning the Kalman filter code: - removed all "cylindrical coordinates" vector and measurement functions; - renamed all preexisting vector and measurement function with their original name. - removed many commented printouts. * Attempt to include hit "sign" / left-right disambiguation: * added "virtual wires" located at the distance-of-closest-approach of the actual wire, on each side of the wire; * added hit sign parameter in KalmanFilter/Hit class; * added a new distance function to KalmanFilter/Hit class calculate the distance of a point to the correct virtual wire depending on the sign; * attempt to modify the "h" function to call new distance function * Fix of a parameter modified by mistake. * Added a second definition of BackwardIndicators in AHDC/KalmanFilter to be able to initialize a vertex. * Added a flag setDefinedVertex to AHDC/KalmanFilter and KFitter to define "hit_beam" vertex. * Reset Niter and ddoca step size parameters to 10, 1.e-8 respectively. * Added reading of wire ADC from the AHDC HitReader, and functions to access ADC for AHDC/Hit/Hit and AHDC/KalmanFilter/Hit. Added filtering of two hits on same superlayer/layer based on ADC (largest ADC is kept) and use info to determine the hit sign. * Added an option to build the initial track with just the hits combination and preset fixed parameters in AHDCEngine. Added a function in AHDC/KalmanFilter/Hit.java to calculate the measurement vector if we have a sign. * Substituted call of default hit vector and hit measurement functions with hit vector and measurement functions that handle hit left/right disambiguation. * Started to reintroduce the hit sign. * Save state: back to status quo before revising sign. * Added variable measurement error for hits with sign defined, with tracks on the wrong side. * Implemented varaible measurement error for signed hits: * if track on right side of wire, normal error; * if track on wrong side of wire, inflated error; Ensured reordering of hits by increasing phi; added exception for "rollover" around phi = pi; * fixed once and for all the convention for hit sign: sign >0 if phi_expected state > phi_wire * Tried to introduce a "pull" to the track on the correct sign of a wire by setting the measurement on the correct "virtual wire" with a larger error. * Revert "Tried to introduce a "pull" to the track on the correct sign of a wire by setting the measurement on the correct "virtual wire" with a larger error." This reverts commit 9bf4715. * Fixed the convention for the "virtual wires": wire "minus" ("plus") at +deltaphi (-deltaphi) since wire x, y position depend on -R*sin(phi), -R cos(phi) respectively. * Improved the functions to calculate hit vector: returns doca if sign is 0 or if sign is good. * Added a hit distance function with goodsign as input, and H (measurement matrix) function with goodsign as an input. * Added (commented) calls of functions with sign. * Added a simple handle to disable reading of MC variables. * Rerolled to fitting with no double hit. * Harmonized simulation flag: - one simulation flag is declared in AHDCengine and defined as false; - it is now propagated into KalmanFilter. * Added a check to read MC hits in AHDC_engine. --------- Co-authored-by: Mathieu Ouillon <67646911+mathieuouillon@users.noreply.github.com> * Petiroc timestamps2 (#512) * Added petiroc board timestamps * Adding CI stuff that is for gitlab modified: common-tools/clas-detector/src/main/java/org/jlab/detector/decode/CLASDecoder4.java modified: common-tools/clas-detector/src/main/java/org/jlab/detector/decode/CodaEventDecoder.java modified: common-tools/clas-detector/src/main/java/org/jlab/detector/decode/DetectorDataDgtz.java modified: etc/bankdefs/hipo4/data.json --------- Co-authored-by: Whitney Armstrong <warmstrong@anl.gov> * bump version * version bump * create a method to decode evio events in a single line to simplify usage in mon12 and ced * new DCRB firmware (#509) * implemented decoding of new DCRB banks with ToT and order labeling of DC hit to use the first in time * removed anused code * printingg exception from DC banks decoding --------- Co-authored-by: Nathan Baltzell <baltzell@gmx.com> * fix: remove `jdtls` files * fix: ignore `jdtls` files * Use pulse time and hide MVTFitter * Change samplingTime * Fix issue * version bump --------- Co-authored-by: raffaelladevita <devita@ge.infn.it> Co-authored-by: tongtongcao <tongtongcao1@gmail.com> Co-authored-by: ziegler <ziegler@enpziegler-mac> Co-authored-by: baltzell <baltzell@gmx.com> Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com> Co-authored-by: MathieuOuillon <mathieu.ouillon1@gmail.com> Co-authored-by: efuchey <efuchey@jlab.org> Co-authored-by: Mathieu Ouillon <67646911+mathieuouillon@users.noreply.github.com> Co-authored-by: Whitney Armstrong <whit@jlab.org> Co-authored-by: Whitney Armstrong <warmstrong@anl.gov> Co-authored-by: Felix Touchte Codjo <felixtouchtecodjo@gmail.com> Co-authored-by: Nathan Baltzell <baltzell@jlab.org>

feat: pre-commit hook to update banks README
52824ee

c-dilksand others added 2 commits March 26, 2025 17:57

test: re-trigger precommit bot
261b170

[pre-commit.ci] auto fixes from pre-commit.com hooks
36d4c13
for more information, see https://pre-commit.ci

c-dilks marked this pull request as ready for review March 26, 2025 21:59

Merge branch 'development' into update-banks-readme
98ee57b

c-dilks enabled auto-merge (squash) March 26, 2025 21:59

This was referenced Mar 26, 2025
bump version #507
Merged
ALERT: Improvement made to the algorithm for generating all track candidates. #508
Merged
New DCRB firmware #472
Closed

baltzell approved these changes Mar 26, 2025
View reviewed changes

c-dilks merged commit b13d761 into developmentMar 26, 2025

baltzell deleted the update-banks-readme branch March 26, 2025 22:37

c-dilks added a commit that referenced this pull request Sep 15, 2025
feat: pre-commit hook to update banks README (#505)
f1b935f

tongtongcao pushed a commit that referenced this pull request Sep 22, 2025
feat: pre-commit hook to update banks README (#505)
2c46b2f

tongtongcao pushed a commit that referenced this pull request Nov 18, 2025
feat: pre-commit hook to update banks README (#505)
e2e36df

tongtongcao pushed a commit that referenced this pull request Nov 21, 2025
feat: pre-commit hook to update banks README (#505)
63b1a20

tongtongcao pushed a commit that referenced this pull request Dec 5, 2025
feat: pre-commit hook to update banks README (#505)
68d7362

tongtongcao pushed a commit that referenced this pull request Dec 5, 2025
feat: pre-commit hook to update banks README (#505)
6c78280

tongtongcao pushed a commit that referenced this pull request Dec 31, 2025
feat: pre-commit hook to update banks README (#505)
2ef2c26

Navigation Menu

Uh oh!

feat: pre-commit hook to update banks README - #505

feat: pre-commit hook to update banks README#505
c-dilks merged 4 commits into
developmentfrom
update-banks-readme

c-dilks commented Mar 24, 2025•
edited
Loading

Uh oh!

c-dilks commented Mar 24, 2025•
edited
Loading

Uh oh!

baltzell commented Mar 25, 2025

Uh oh!

c-dilks commented Mar 26, 2025

Uh oh!

c-dilks commented Mar 26, 2025

Uh oh!

c-dilks commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

c-dilks commented Mar 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c-dilks commented Mar 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

baltzell commented Mar 25, 2025

Uh oh!

c-dilks commented Mar 26, 2025

Uh oh!

c-dilks commented Mar 26, 2025

Uh oh!

c-dilks commented Mar 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

c-dilks commented Mar 24, 2025•
edited
Loading

c-dilks commented Mar 24, 2025•
edited
Loading