Skip to content

build!: various cleanups - #515

Merged
baltzell merged 30 commits into
developmentfrom
one-version-num
May 9, 2025
Merged

build!: various cleanups#515
baltzell merged 30 commits into
developmentfrom
one-version-num

Conversation

@c-dilks

@c-dilksc-dilks commented Mar 28, 2025

Copy link
Copy Markdown
Member

Important

If you are a developer, after this PR is merged, please use the --clean option when you run build-coatjava.sh for the first time! This will prevent old JAR files from creeping into your new build.

build-coatjava.sh updates

  • now optionally runs mvn clean, with the new option --clean
    • running mvn clean every time was the previous default behavior, but only for common-tools/coat-lib POM
    • optionally running mvn clean is more in line with other build automation tools
  • installation prefix now uses an absolute path rather than relative path ./coatjava; this should prevent the user from accidentally removing some other directory named coatjava

version-bump.sh updates

  • no more need to specify the old version number, e.g.:
./version-bump.sh 13.0.0
  • now uses mvn to directly update the project version, rather than sed
    • sed is still needed for hard-coded version numbers in a couple scripts
    • version number in install-clara is now bumped
    • specifying the version number in one place, such as a parent POM property, is practically a no-go in Maven; using a mvn command is the preferred way
  • automatically creates a new git branch and runs git commit; the user may then run git push and open a PR
    • requires the user to start from the development branch
    • add the argument --no-git to disable this git automation

POM changes

  • Combined common-tools/coat-lib POM with common-tools POM
    • common-tools/coat-lib is now just another module, instead of independent
    • removed unused common-tools/parent/pom.xml
    • removed unused common-tools/build.sh, and common-tools/README.md, its only reference
  • POM project version numbers are now up-to-date everywhere
    • this is a result of using mvn instead of sed to bump the version
    • for many JARs, we had a lot of 1.0 and 1.1 snapshot versions, and it appears their version numbers were never bumped
    • some POM modules also now use the up-to-date version number, e.g., common-tools/cnuphys/magfield
  • see comments below for comparisons of the installation tree and JAR files

@c-dilks

Copy link
Copy Markdown
MemberAuthor

So far, the only difference of the installation tree is the version number is now corrected on the following JARs:

1c1< coatjava-BEFORE/coatjava---> coatjava-AFTER/coatjava1281,1302c1281,1302< │ │ ├── clas12detector-alert-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-band-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-bg-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-cnd-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-cvt-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-dc-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-eb-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-ec-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-fmt-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-ft-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-htcc-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-ltcc-1.1-SNAPSHOT.jar< │ │ ├── clas12detector-mc-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-mltn-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-postproc-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-raster-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-rich-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-rtpc-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-swaps-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-tof-1.0-SNAPSHOT.jar< │ │ ├── clas12detector-urwell-1.0-SNAPSHOT.jar< │ │ └── clas12detector-vtx-1.0-SNAPSHOT.jar---> │ │ ├── clas12detector-alert-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-band-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-bg-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-cnd-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-cvt-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-dc-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-eb-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-ec-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-fmt-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-ft-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-htcc-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-ltcc-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-mc-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-mltn-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-postproc-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-raster-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-rich-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-rtpc-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-swaps-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-tof-12.0.0-SNAPSHOT.jar> │ │ ├── clas12detector-urwell-12.0.0-SNAPSHOT.jar> │ │ └── clas12detector-vtx-12.0.0-SNAPSHOT.jar

@c-dilks

c-dilks commented Mar 31, 2025

Copy link
Copy Markdown
MemberAuthor

All JAR file contents are exactly the same except for coat-libs-12.0.1t-SNAPSHOT.jar (the shade). Comparing the version from development branch ("before") to this new version ("after"):

  • "before" is mostly a subset of "after", i.e., every class in "before" is found in "after" but not every class in "after" is found in "before"
    • except for org/apache/commons/lang3/time/FastDateParser$TextStrategy.class, which is only found in "before"

The only differences in what's included in this shaded JAR that are not from our local POM version number corrections are:

59c59< [INFO] Including org.apache.commons:commons-lang3:jar:3.3.2 in the shaded jar.---> [INFO] Including org.apache.commons:commons-lang3:jar:3.17.0 in the shaded jar.142c142< [INFO] Including org.slf4j:slf4j-api:jar:1.7.5 in the shaded jar.---> [INFO] Including org.slf4j:slf4j-api:jar:2.0.16 in the shaded jar.
Click here to view all the differences between the shaded JAR contents ("before" -> "after")
21625a21626,21636> org/apache/commons/lang3/AppendableJoiner$1.class> org/apache/commons/lang3/AppendableJoiner$Builder.class> org/apache/commons/lang3/AppendableJoiner.class> org/apache/commons/lang3/arch/> org/apache/commons/lang3/arch/package-info.class> org/apache/commons/lang3/arch/Processor$Arch.class> org/apache/commons/lang3/arch/Processor$Type.class> org/apache/commons/lang3/arch/Processor.class> org/apache/commons/lang3/ArchUtils.class> org/apache/commons/lang3/ArrayFill.class> org/apache/commons/lang3/ArraySorter.class21629a21641> org/apache/commons/lang3/builder/AbstractSupplier.class21633,21641d21644< org/apache/commons/lang3/builder/DiffBuilder$10.class< org/apache/commons/lang3/builder/DiffBuilder$11.class< org/apache/commons/lang3/builder/DiffBuilder$12.class< org/apache/commons/lang3/builder/DiffBuilder$13.class< org/apache/commons/lang3/builder/DiffBuilder$14.class< org/apache/commons/lang3/builder/DiffBuilder$15.class< org/apache/commons/lang3/builder/DiffBuilder$16.class< org/apache/commons/lang3/builder/DiffBuilder$17.class< org/apache/commons/lang3/builder/DiffBuilder$18.class21643,21650c21646,21647< org/apache/commons/lang3/builder/DiffBuilder$2.class< org/apache/commons/lang3/builder/DiffBuilder$3.class< org/apache/commons/lang3/builder/DiffBuilder$4.class< org/apache/commons/lang3/builder/DiffBuilder$5.class< org/apache/commons/lang3/builder/DiffBuilder$6.class< org/apache/commons/lang3/builder/DiffBuilder$7.class< org/apache/commons/lang3/builder/DiffBuilder$8.class< org/apache/commons/lang3/builder/DiffBuilder$9.class---> org/apache/commons/lang3/builder/DiffBuilder$Builder.class> org/apache/commons/lang3/builder/DiffBuilder$SDiff.class21652a21650> org/apache/commons/lang3/builder/DiffExclude.class21654a21653> org/apache/commons/lang3/builder/EqualsExclude.class21655a21655> org/apache/commons/lang3/builder/HashCodeExclude.class21656a21657,21658> org/apache/commons/lang3/builder/MultilineRecursiveToStringStyle.class> org/apache/commons/lang3/builder/package-info.class21657a21660,21663> org/apache/commons/lang3/builder/Reflection.class> org/apache/commons/lang3/builder/ReflectionDiffBuilder$1.class> org/apache/commons/lang3/builder/ReflectionDiffBuilder$Builder.class> org/apache/commons/lang3/builder/ReflectionDiffBuilder.class21660a21667> org/apache/commons/lang3/builder/ToStringExclude.class21661a21669> org/apache/commons/lang3/builder/ToStringStyle$JsonToStringStyle.class21662a21671> org/apache/commons/lang3/builder/ToStringStyle$NoClassNameToStringStyle.class21666a21676,21677> org/apache/commons/lang3/builder/ToStringSummary.class> org/apache/commons/lang3/CachedRandomBits.class21672a21684> org/apache/commons/lang3/Charsets.class21674a21687> org/apache/commons/lang3/ClassLoaderUtils.class21676d21688< org/apache/commons/lang3/ClassUtils$1$1.class21678d21689< org/apache/commons/lang3/ClassUtils$2$1.class21681a21693,21698> org/apache/commons/lang3/compare/> org/apache/commons/lang3/compare/ComparableUtils$1.class> org/apache/commons/lang3/compare/ComparableUtils$ComparableCheckBuilder.class> org/apache/commons/lang3/compare/ComparableUtils.class> org/apache/commons/lang3/compare/ObjectToStringComparator.class> org/apache/commons/lang3/compare/package-info.class21682a21700,21709> org/apache/commons/lang3/concurrent/AbstractCircuitBreaker$1.class> org/apache/commons/lang3/concurrent/AbstractCircuitBreaker$State$1.class> org/apache/commons/lang3/concurrent/AbstractCircuitBreaker$State$2.class> org/apache/commons/lang3/concurrent/AbstractCircuitBreaker$State.class> org/apache/commons/lang3/concurrent/AbstractCircuitBreaker.class> org/apache/commons/lang3/concurrent/AbstractConcurrentInitializer$AbstractBuilder.class> org/apache/commons/lang3/concurrent/AbstractConcurrentInitializer.class> org/apache/commons/lang3/concurrent/AbstractFutureProxy.class> org/apache/commons/lang3/concurrent/AtomicInitializer$1.class> org/apache/commons/lang3/concurrent/AtomicInitializer$Builder.class21683a21711,21712> org/apache/commons/lang3/concurrent/AtomicSafeInitializer$1.class> org/apache/commons/lang3/concurrent/AtomicSafeInitializer$Builder.class21684a21714,21715> org/apache/commons/lang3/concurrent/BackgroundInitializer$1.class> org/apache/commons/lang3/concurrent/BackgroundInitializer$Builder.class21690a21722,21724> org/apache/commons/lang3/concurrent/CircuitBreaker.class> org/apache/commons/lang3/concurrent/CircuitBreakingException.class> org/apache/commons/lang3/concurrent/Computable.class21696a21731,21739> org/apache/commons/lang3/concurrent/EventCountCircuitBreaker$1.class> org/apache/commons/lang3/concurrent/EventCountCircuitBreaker$CheckIntervalData.class> org/apache/commons/lang3/concurrent/EventCountCircuitBreaker$StateStrategy.class> org/apache/commons/lang3/concurrent/EventCountCircuitBreaker$StateStrategyClosed.class> org/apache/commons/lang3/concurrent/EventCountCircuitBreaker$StateStrategyOpen.class> org/apache/commons/lang3/concurrent/EventCountCircuitBreaker.class> org/apache/commons/lang3/concurrent/FutureTasks.class> org/apache/commons/lang3/concurrent/LazyInitializer$1.class> org/apache/commons/lang3/concurrent/LazyInitializer$Builder.class21697a21741,21747> org/apache/commons/lang3/concurrent/locks/> org/apache/commons/lang3/concurrent/locks/LockingVisitors$LockVisitor.class> org/apache/commons/lang3/concurrent/locks/LockingVisitors$ReadWriteLockVisitor.class> org/apache/commons/lang3/concurrent/locks/LockingVisitors$StampedLockVisitor.class> org/apache/commons/lang3/concurrent/locks/LockingVisitors.class> org/apache/commons/lang3/concurrent/locks/package-info.class> org/apache/commons/lang3/concurrent/Memoizer.class21701c21751,21752< org/apache/commons/lang3/concurrent/TimedSemaphore$1.class---> org/apache/commons/lang3/concurrent/package-info.class> org/apache/commons/lang3/concurrent/ThresholdCircuitBreaker.class21702a21754,21757> org/apache/commons/lang3/concurrent/UncheckedExecutionException.class> org/apache/commons/lang3/concurrent/UncheckedFuture.class> org/apache/commons/lang3/concurrent/UncheckedFutureImpl.class> org/apache/commons/lang3/concurrent/UncheckedTimeoutException.class21703a21759> org/apache/commons/lang3/DoubleRange.class21709a21766> org/apache/commons/lang3/event/package-info.class21716a21774,21845> org/apache/commons/lang3/exception/package-info.class> org/apache/commons/lang3/exception/UncheckedException.class> org/apache/commons/lang3/exception/UncheckedIllegalAccessException.class> org/apache/commons/lang3/exception/UncheckedInterruptedException.class> org/apache/commons/lang3/exception/UncheckedReflectiveOperationException.class> org/apache/commons/lang3/function/> org/apache/commons/lang3/function/BooleanConsumer.class> org/apache/commons/lang3/function/Consumers.class> org/apache/commons/lang3/function/FailableBiConsumer.class> org/apache/commons/lang3/function/FailableBiFunction.class> org/apache/commons/lang3/function/FailableBiPredicate.class> org/apache/commons/lang3/function/FailableBooleanSupplier.class> org/apache/commons/lang3/function/FailableCallable.class> org/apache/commons/lang3/function/Failable.class> org/apache/commons/lang3/function/FailableConsumer.class> org/apache/commons/lang3/function/FailableDoubleBinaryOperator.class> org/apache/commons/lang3/function/FailableDoubleConsumer.class> org/apache/commons/lang3/function/FailableDoubleFunction.class> org/apache/commons/lang3/function/FailableDoublePredicate.class> org/apache/commons/lang3/function/FailableDoubleSupplier.class> org/apache/commons/lang3/function/FailableDoubleToIntFunction.class> org/apache/commons/lang3/function/FailableDoubleToLongFunction.class> org/apache/commons/lang3/function/FailableDoubleUnaryOperator.class> org/apache/commons/lang3/function/FailableFunction.class> org/apache/commons/lang3/function/FailableIntBinaryOperator.class> org/apache/commons/lang3/function/FailableIntConsumer.class> org/apache/commons/lang3/function/FailableIntFunction.class> org/apache/commons/lang3/function/FailableIntPredicate.class> org/apache/commons/lang3/function/FailableIntSupplier.class> org/apache/commons/lang3/function/FailableIntToDoubleFunction.class> org/apache/commons/lang3/function/FailableIntToLongFunction.class> org/apache/commons/lang3/function/FailableIntUnaryOperator.class> org/apache/commons/lang3/function/FailableLongBinaryOperator.class> org/apache/commons/lang3/function/FailableLongConsumer.class> org/apache/commons/lang3/function/FailableLongFunction.class> org/apache/commons/lang3/function/FailableLongPredicate.class> org/apache/commons/lang3/function/FailableLongSupplier.class> org/apache/commons/lang3/function/FailableLongToDoubleFunction.class> org/apache/commons/lang3/function/FailableLongToIntFunction.class> org/apache/commons/lang3/function/FailableLongUnaryOperator.class> org/apache/commons/lang3/function/FailableObjDoubleConsumer.class> org/apache/commons/lang3/function/FailableObjIntConsumer.class> org/apache/commons/lang3/function/FailableObjLongConsumer.class> org/apache/commons/lang3/function/FailablePredicate.class> org/apache/commons/lang3/function/FailableRunnable.class> org/apache/commons/lang3/function/FailableShortSupplier.class> org/apache/commons/lang3/function/FailableSupplier.class> org/apache/commons/lang3/function/FailableToDoubleBiFunction.class> org/apache/commons/lang3/function/FailableToDoubleFunction.class> org/apache/commons/lang3/function/FailableToIntBiFunction.class> org/apache/commons/lang3/function/FailableToIntFunction.class> org/apache/commons/lang3/function/FailableToLongBiFunction.class> org/apache/commons/lang3/function/FailableToLongFunction.class> org/apache/commons/lang3/function/Functions.class> org/apache/commons/lang3/function/IntToCharFunction.class> org/apache/commons/lang3/function/MethodInvokers.class> org/apache/commons/lang3/function/package-info.class> org/apache/commons/lang3/Functions$FailableBiConsumer.class> org/apache/commons/lang3/Functions$FailableBiFunction.class> org/apache/commons/lang3/Functions$FailableBiPredicate.class> org/apache/commons/lang3/Functions$FailableCallable.class> org/apache/commons/lang3/Functions$FailableConsumer.class> org/apache/commons/lang3/Functions$FailableFunction.class> org/apache/commons/lang3/Functions$FailablePredicate.class> org/apache/commons/lang3/Functions$FailableRunnable.class> org/apache/commons/lang3/Functions$FailableSupplier.class> org/apache/commons/lang3/Functions.class> org/apache/commons/lang3/function/Suppliers.class> org/apache/commons/lang3/function/ToBooleanBiFunction.class> org/apache/commons/lang3/function/TriConsumer.class> org/apache/commons/lang3/function/TriFunction.class> org/apache/commons/lang3/IntegerRange.class21719a21849> org/apache/commons/lang3/LongRange.class21723a21854> org/apache/commons/lang3/math/package-info.class21733a21865> org/apache/commons/lang3/mutable/package-info.class21734a21867> org/apache/commons/lang3/NumberRange.class21736a21870> org/apache/commons/lang3/package-info.class21744a21879> org/apache/commons/lang3/reflect/MemberUtils$Executable.class21746a21882> org/apache/commons/lang3/reflect/package-info.class21754a21891,21892> org/apache/commons/lang3/RegExUtils.class> org/apache/commons/lang3/RuntimeEnvironment.class21757a21896,21908> org/apache/commons/lang3/stream/> org/apache/commons/lang3/stream/IntStreams.class> org/apache/commons/lang3/stream/LangCollectors$1.class> org/apache/commons/lang3/stream/LangCollectors$SimpleCollector.class> org/apache/commons/lang3/stream/LangCollectors.class> org/apache/commons/lang3/stream/package-info.class> org/apache/commons/lang3/Streams$ArrayCollector.class> org/apache/commons/lang3/Streams$FailableStream.class> org/apache/commons/lang3/Streams.class> org/apache/commons/lang3/stream/Streams$ArrayCollector.class> org/apache/commons/lang3/stream/Streams$EnumerationSpliterator.class> org/apache/commons/lang3/stream/Streams$FailableStream.class> org/apache/commons/lang3/stream/Streams.class21761a21913> org/apache/commons/lang3/SystemProperties.class21767a21920> org/apache/commons/lang3/text/package-info.class21771a21925> org/apache/commons/lang3/text/StrLookup$1.class21772a21927> org/apache/commons/lang3/text/StrLookup$SystemPropertiesStrLookup.class21792a21948> org/apache/commons/lang3/text/translate/package-info.class21796a21953,21959> org/apache/commons/lang3/ThreadUtils$1.class> org/apache/commons/lang3/ThreadUtils$AlwaysTruePredicate.class> org/apache/commons/lang3/ThreadUtils$NamePredicate.class> org/apache/commons/lang3/ThreadUtils$ThreadGroupPredicate.class> org/apache/commons/lang3/ThreadUtils$ThreadIdPredicate.class> org/apache/commons/lang3/ThreadUtils$ThreadPredicate.class> org/apache/commons/lang3/ThreadUtils.class21797a21961,21963> org/apache/commons/lang3/time/AbstractFormatCache$ArrayKey.class> org/apache/commons/lang3/time/AbstractFormatCache.class> org/apache/commons/lang3/time/CalendarUtils.class21801a21968> org/apache/commons/lang3/time/DateUtils$ModifyType.class21804a21972,21973> org/apache/commons/lang3/time/DurationUtils$1.class> org/apache/commons/lang3/time/DurationUtils.class21810a21980,21981> org/apache/commons/lang3/time/FastDateParser$5.class> org/apache/commons/lang3/time/FastDateParser$CaseInsensitiveTextStrategy.class21811a21983> org/apache/commons/lang3/time/FastDateParser$ISO8601TimeZoneStrategy.class21812a21985,21986> org/apache/commons/lang3/time/FastDateParser$PatternStrategy.class> org/apache/commons/lang3/time/FastDateParser$StrategyAndWidth.class21814c21988,21989< org/apache/commons/lang3/time/FastDateParser$TextStrategy.class---> org/apache/commons/lang3/time/FastDateParser$StrategyParser.class> org/apache/commons/lang3/time/FastDateParser$TimeZoneStrategy$TzInfo.class21817a21993,21994> org/apache/commons/lang3/time/FastDatePrinter$DayInWeekField.class> org/apache/commons/lang3/time/FastDatePrinter$Iso8601_Rule.class21832a22010> org/apache/commons/lang3/time/FastDatePrinter$WeekYear.class21834,21835c22012,22014< org/apache/commons/lang3/time/FormatCache$MultipartKey.class< org/apache/commons/lang3/time/FormatCache.class---> org/apache/commons/lang3/time/FastTimeZone.class> org/apache/commons/lang3/time/GmtTimeZone.class> org/apache/commons/lang3/time/package-info.class21843a22023> org/apache/commons/lang3/time/TimeZones.class21848a22029> org/apache/commons/lang3/tuple/package-info.class21850a22032,22034> org/apache/commons/lang3/util/> org/apache/commons/lang3/util/FluentBitSet.class> org/apache/commons/lang3/util/package-info.class34509a34694,34701> org/slf4j/event/> org/slf4j/event/DefaultLoggingEvent.class> org/slf4j/event/EventConstants.class> org/slf4j/event/EventRecordingLogger.class> org/slf4j/event/KeyValuePair.class> org/slf4j/event/Level.class> org/slf4j/event/LoggingEvent.class> org/slf4j/event/SubstituteLoggingEvent.class34510a34703> org/slf4j/helpers/AbstractLogger.class34512a34706> org/slf4j/helpers/BasicMDCAdapter$1.class34513a34708> org/slf4j/helpers/CheckReturnValue.class34514a34710> org/slf4j/helpers/LegacyAbstractLogger.class34517a34714> org/slf4j/helpers/NOP_FallbackServiceProvider.class34520a34718,34723> org/slf4j/helpers/NormalizedParameters.class> org/slf4j/helpers/Reporter$Level.class> org/slf4j/helpers/Reporter$TargetChoice.class> org/slf4j/helpers/Reporter.class> org/slf4j/helpers/Slf4jEnvUtil.class> org/slf4j/helpers/SubstituteLogger.class34521a34725,34728> org/slf4j/helpers/SubstituteServiceProvider.class> org/slf4j/helpers/ThreadLocalMapOfStacks.class> org/slf4j/helpers/Util$1.class> org/slf4j/helpers/Util$ClassContextSecurityManager.class34530a34738> org/slf4j/LoggerFactoryFriend.class34532a34741,34742> org/slf4j/MDC$1.class> org/slf4j/MDC$MDCCloseable.class34541a34752,34754> org/slf4j/spi/CallerBoundaryAware.class> org/slf4j/spi/DefaultLoggingEventBuilder$1.class> org/slf4j/spi/DefaultLoggingEventBuilder.class34543a34757,34758> org/slf4j/spi/LoggingEventAware.class> org/slf4j/spi/LoggingEventBuilder.class34545a34761,34762> org/slf4j/spi/NOPLoggingEventBuilder.class> org/slf4j/spi/SLF4JServiceProvider.class

And here are the full JAR contents for each:

@c-dilks
c-dilks marked this pull request as ready for review March 31, 2025 21:23
@c-dilks

Copy link
Copy Markdown
MemberAuthor

Looks like the "Coatjava-CI" failures are unrelated ("too many connections" problem). Validation is failing on simulation (unrelated). We did get a lucky passing job a couple commits ago, but we need to be sure this branch works before merging.

@c-dilks

Copy link
Copy Markdown
MemberAuthor

@raffaelladevita and @baltzell: I requested reviews, but I also highly recommend testing this branch on your own, since the CI doesn't test everything.

If you test, clone this repository to a new directory, just in case things go awry and so this doesn't get in the way of other coatjava work you may be doing.

@baltzellbaltzell mentioned this pull request Apr 5, 2025
4 tasks
@baltzell

Copy link
Copy Markdown
Collaborator

as soon as RG-L gets out of commissioning phase ...

@c-dilks

Copy link
Copy Markdown
MemberAuthor

conflicts resolved!

@raffaelladevita

Copy link
Copy Markdown
Collaborator

I compiled it and ran a few tests. I got the following warning when installing Clara: is that because of the "t" in the version number?

./install-clara aaa
WARNING: COATJAVA doesn't look like a local installation nor version number: 12.0.1t

@c-dilks

Copy link
Copy Markdown
MemberAuthor

I compiled it and ran a few tests. I got the following warning when installing Clara: is that because of the "t" in the version number?

./install-clara aaa
WARNING: COATJAVA doesn't look like a local installation nor version number: 12.0.1t

Yes, fixed the regex in the latest commit 9b4da9a

@baltzell
baltzell merged commit ea7e1d2 into developmentMay 9, 2025
@baltzell
baltzell deleted the one-version-num branch May 9, 2025 20:16
c-dilks added a commit that referenced this pull request Sep 15, 2025
* modified: maven-settings.xml
* modified: maven-settings.xml
* modified: build-coatjava.sh
* new file: bumpo.sh
* build: deleted `common-tools/parent/pom.xml` since it is unused
* refactor: delete `common-tools/build.sh` and `common-tools/README.md`, since not used
* build!: combine `common-tools/coat-lib` POM with `common-tools` POM
* fix: replace `version-bump.sh`
* fix: revert maven-settings.xml
* build: all POMs should be at 12.0.0
* feat: `version-bump` makes a new git branch and commits
* style: better printout
* fix: ignore `jdtls` files
* build: make clean-build be optional
* fix: restore `coat-lib` shade deps
* test: script for dumping jar contents
* fix: re-bump to 12.0.1t
* fix: remove FIXME comment
* fix: bump `install-clara` version
* fix: version bump should bump shade dependencies too
* fix: remove test script
* fix: be more careful with `rm`-ing `coatjava`
* fix: unbound `new_branch`
* fix: clarify printout
* fix: sync version numbers
* fix: `install-clara` version check of `coatjava` should allow `/.*t$/`
tongtongcao pushed a commit that referenced this pull request Sep 22, 2025
* modified: maven-settings.xml
* modified: maven-settings.xml
* modified: build-coatjava.sh
* new file: bumpo.sh
* build: deleted `common-tools/parent/pom.xml` since it is unused
* refactor: delete `common-tools/build.sh` and `common-tools/README.md`, since not used
* build!: combine `common-tools/coat-lib` POM with `common-tools` POM
* fix: replace `version-bump.sh`
* fix: revert maven-settings.xml
* build: all POMs should be at 12.0.0
* feat: `version-bump` makes a new git branch and commits
* style: better printout
* fix: ignore `jdtls` files
* build: make clean-build be optional
* fix: restore `coat-lib` shade deps
* test: script for dumping jar contents
* fix: re-bump to 12.0.1t
* fix: remove FIXME comment
* fix: bump `install-clara` version
* fix: version bump should bump shade dependencies too
* fix: remove test script
* fix: be more careful with `rm`-ing `coatjava`
* fix: unbound `new_branch`
* fix: clarify printout
* fix: sync version numbers
* fix: `install-clara` version check of `coatjava` should allow `/.*t$/`
tongtongcao pushed a commit that referenced this pull request Nov 18, 2025
* modified: maven-settings.xml
* modified: maven-settings.xml
* modified: build-coatjava.sh
* new file: bumpo.sh
* build: deleted `common-tools/parent/pom.xml` since it is unused
* refactor: delete `common-tools/build.sh` and `common-tools/README.md`, since not used
* build!: combine `common-tools/coat-lib` POM with `common-tools` POM
* fix: replace `version-bump.sh`
* fix: revert maven-settings.xml
* build: all POMs should be at 12.0.0
* feat: `version-bump` makes a new git branch and commits
* style: better printout
* fix: ignore `jdtls` files
* build: make clean-build be optional
* fix: restore `coat-lib` shade deps
* test: script for dumping jar contents
* fix: re-bump to 12.0.1t
* fix: remove FIXME comment
* fix: bump `install-clara` version
* fix: version bump should bump shade dependencies too
* fix: remove test script
* fix: be more careful with `rm`-ing `coatjava`
* fix: unbound `new_branch`
* fix: clarify printout
* fix: sync version numbers
* fix: `install-clara` version check of `coatjava` should allow `/.*t$/`
tongtongcao pushed a commit that referenced this pull request Nov 21, 2025
* modified: maven-settings.xml
* modified: maven-settings.xml
* modified: build-coatjava.sh
* new file: bumpo.sh
* build: deleted `common-tools/parent/pom.xml` since it is unused
* refactor: delete `common-tools/build.sh` and `common-tools/README.md`, since not used
* build!: combine `common-tools/coat-lib` POM with `common-tools` POM
* fix: replace `version-bump.sh`
* fix: revert maven-settings.xml
* build: all POMs should be at 12.0.0
* feat: `version-bump` makes a new git branch and commits
* style: better printout
* fix: ignore `jdtls` files
* build: make clean-build be optional
* fix: restore `coat-lib` shade deps
* test: script for dumping jar contents
* fix: re-bump to 12.0.1t
* fix: remove FIXME comment
* fix: bump `install-clara` version
* fix: version bump should bump shade dependencies too
* fix: remove test script
* fix: be more careful with `rm`-ing `coatjava`
* fix: unbound `new_branch`
* fix: clarify printout
* fix: sync version numbers
* fix: `install-clara` version check of `coatjava` should allow `/.*t$/`
tongtongcao pushed a commit that referenced this pull request Dec 5, 2025
* modified: maven-settings.xml
* modified: maven-settings.xml
* modified: build-coatjava.sh
* new file: bumpo.sh
* build: deleted `common-tools/parent/pom.xml` since it is unused
* refactor: delete `common-tools/build.sh` and `common-tools/README.md`, since not used
* build!: combine `common-tools/coat-lib` POM with `common-tools` POM
* fix: replace `version-bump.sh`
* fix: revert maven-settings.xml
* build: all POMs should be at 12.0.0
* feat: `version-bump` makes a new git branch and commits
* style: better printout
* fix: ignore `jdtls` files
* build: make clean-build be optional
* fix: restore `coat-lib` shade deps
* test: script for dumping jar contents
* fix: re-bump to 12.0.1t
* fix: remove FIXME comment
* fix: bump `install-clara` version
* fix: version bump should bump shade dependencies too
* fix: remove test script
* fix: be more careful with `rm`-ing `coatjava`
* fix: unbound `new_branch`
* fix: clarify printout
* fix: sync version numbers
* fix: `install-clara` version check of `coatjava` should allow `/.*t$/`
tongtongcao pushed a commit that referenced this pull request Dec 5, 2025
* modified: maven-settings.xml
* modified: maven-settings.xml
* modified: build-coatjava.sh
* new file: bumpo.sh
* build: deleted `common-tools/parent/pom.xml` since it is unused
* refactor: delete `common-tools/build.sh` and `common-tools/README.md`, since not used
* build!: combine `common-tools/coat-lib` POM with `common-tools` POM
* fix: replace `version-bump.sh`
* fix: revert maven-settings.xml
* build: all POMs should be at 12.0.0
* feat: `version-bump` makes a new git branch and commits
* style: better printout
* fix: ignore `jdtls` files
* build: make clean-build be optional
* fix: restore `coat-lib` shade deps
* test: script for dumping jar contents
* fix: re-bump to 12.0.1t
* fix: remove FIXME comment
* fix: bump `install-clara` version
* fix: version bump should bump shade dependencies too
* fix: remove test script
* fix: be more careful with `rm`-ing `coatjava`
* fix: unbound `new_branch`
* fix: clarify printout
* fix: sync version numbers
* fix: `install-clara` version check of `coatjava` should allow `/.*t$/`
tongtongcao pushed a commit that referenced this pull request Dec 31, 2025
* modified: maven-settings.xml
* modified: maven-settings.xml
* modified: build-coatjava.sh
* new file: bumpo.sh
* build: deleted `common-tools/parent/pom.xml` since it is unused
* refactor: delete `common-tools/build.sh` and `common-tools/README.md`, since not used
* build!: combine `common-tools/coat-lib` POM with `common-tools` POM
* fix: replace `version-bump.sh`
* fix: revert maven-settings.xml
* build: all POMs should be at 12.0.0
* feat: `version-bump` makes a new git branch and commits
* style: better printout
* fix: ignore `jdtls` files
* build: make clean-build be optional
* fix: restore `coat-lib` shade deps
* test: script for dumping jar contents
* fix: re-bump to 12.0.1t
* fix: remove FIXME comment
* fix: bump `install-clara` version
* fix: version bump should bump shade dependencies too
* fix: remove test script
* fix: be more careful with `rm`-ing `coatjava`
* fix: unbound `new_branch`
* fix: clarify printout
* fix: sync version numbers
* fix: `install-clara` version check of `coatjava` should allow `/.*t$/`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@c-dilks@baltzell@raffaelladevita