Skip to content

Fix flag wrapping for getInstalledPackagesReflect#613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingMatrix merged 1 commit into from
Mar 31, 2026
Merged

Fix flag wrapping for getInstalledPackagesReflect #613

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions daemon/src/main/java/org/lsposed/lspd/service/PackageService.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -103,11 +103,17 @@ public class PackageService {
getInstalledPackagesMethod = method;
}

private static List<PackageInfo> getInstalledPackagesReflect(IPackageManager pm, Object flags, int userId) {
private static List<PackageInfo> getInstalledPackagesReflect(IPackageManager pm, int flags, int userId) {
if (getInstalledPackagesMethod == null || pm == null)
return Collections.emptyList();
try {
Object result = getInstalledPackagesMethod.invoke(pm, flags, userId);
Object flagsObj;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
flagsObj = (long) flags;
} else {
flagsObj = (int) flags;
}
Object result = getInstalledPackagesMethod.invoke(pm, flagsObj, userId);
if (result instanceof ParceledListSlice) {
// noinspection unchecked
return ((ParceledListSlice<PackageInfo>) result).getList();
Expand DownExpand Up@@ -184,13 +190,11 @@ public static ParcelableListSlice<PackageInfo> getInstalledPackagesFromAllUsers(
throws RemoteException {
List<PackageInfo> res = new ArrayList<>();
IPackageManager pm = getPackageManager();
if (pm == null)
return ParcelableListSlice.emptyList();
if (pm == null) return ParcelableListSlice.emptyList();
// Prepare flags once outside the loop
Object flagsObj = (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) ? (long) flags : flags;
for (var user : UserService.getUsers()) {
// Use the reflective helper instead of direct AIDL calls
List<PackageInfo> infos = getInstalledPackagesReflect(pm, flagsObj, user.id);
List<PackageInfo> infos = getInstalledPackagesReflect(pm, flags, user.id);
res.addAll(infos.parallelStream()
.filter(info -> info.applicationInfo != null
&& info.applicationInfo.uid / PER_USER_RANGE == user.id)
Expand Down
Loading