Skip to content

Fix Vector update metadata and version checks - #764

Closed
Shallow-dusty wants to merge 4 commits into
JingMatrix:masterfrom
Shallow-dusty:codex/fix-vector-update-checks
Closed

Fix Vector update metadata and version checks#764
Shallow-dusty wants to merge 4 commits into
JingMatrix:masterfrom
Shallow-dusty:codex/fix-vector-update-checks

Conversation

@Shallow-dusty

Copy link
Copy Markdown
Contributor

Summary

  • Point manager update checks and update/install metadata at JingMatrix/Vector instead of the old JingMatrix/LSPosed URLs.
  • Parse release asset version codes with a regex so current asset names such as Vector-v2.0-3021-Release.zip are handled robustly.
  • Only show the manager update prompt when the confirmed latest release version code is greater than the installed build.
  • Move native compile-time macro values from Gradle cFlags/cppFlags string injection into CMake target_compile_definitions, avoiding Windows quoting issues for string macros.

Why

The manager could report that Vector needed an update even when the installed build was newer than the latest published release. This happened because the update check still targeted the old LSPosed release endpoint and because the stale/failed-check fallback treated old check timestamps as an update condition.

Validation

  • Confirmed the latest JingMatrix/Vector release assets are named Vector-v2.0-3021-Debug.zip and Vector-v2.0-3021-Release.zip.
  • Ran git diff --check origin/master..HEAD.
  • Ran ./gradlew.bat --no-daemon :app:assembleDebug :app:compileDebugJavaWithJavac :zygisk:zipDebug.
  • Installed and verified the patched debug module on a OnePlus 12 / PJD110 through KernelSU:
    • Vector module: v2.0 (3043)
    • KernelSU module state: enabled=true, update=false
    • Manager overview: framework 2.0 (3043), API 101
    • Existing modules such as LuckyTool and Scene remained visible.

./gradlew.bat --no-daemon check was also attempted, but it failed before project checks ran because Gradle could not download lint dependencies from Google Maven / Maven Central due to TLS handshake failures in this local network environment.

@Shallow-dusty
Shallow-dusty marked this pull request as ready for review June 22, 2026 02:16
CopilotAI review requested due to automatic review settings June 22, 2026 02:16

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Vector’s manager/module update metadata to reference the JingMatrix/Vector repository, improves parsing of release asset version codes from current asset naming schemes, tightens the manager “update available” prompt logic, and moves native compile-time macro injection into CMake compile definitions to avoid Gradle flag quoting issues (notably on Windows).

Changes:

  • Update update/install URLs (update.json, module.prop, app strings, and GitHub API endpoint) from JingMatrix/LSPosed to JingMatrix/Vector.
  • Parse release asset version codes via regex and only indicate an update when latest_version > BuildConfig.VERSION_CODE.
  • Replace Gradle cFlags/cppFlags macro injection with CMake target_compile_definitions driven by -D CMake arguments.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
zygisk/update.jsonPoints Zygisk module update metadata to Vector release/changelog URLs.
zygisk/src/main/cpp/CMakeLists.txtMoves injected package/UID/manager package macros into target_compile_definitions.
zygisk/module/module.propUpdates module updateJson URL to the Vector repo.
zygisk/build.gradle.ktsPasses injected package parameters to CMake via arguments instead of compiler flags.
native/CMakeLists.txtDefines VERSION_CODE/NAME via target_compile_definitions from CMake args.
magisk-loader/update/zygisk.jsonUpdates Magisk loader metadata URLs to Vector.
build.gradle.ktsPasses version info to CMake via -DVECTOR_VERSION_* arguments and removes c/cpp flags injection.
app/src/main/res/values/strings_untranslatable.xmlUpdates install/latest URLs to Vector.
app/src/main/java/org/lsposed/manager/util/UpdateUtil.javaSwitches update check to Vector releases API; parses versionCode via regex; simplifies update-needed logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadapp/src/main/java/org/lsposed/manager/util/UpdateUtil.java Outdated
@JingMatrix

Copy link
Copy Markdown
Owner

I will fix UI issues on my refactor UI #796

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Shallow-dusty@JingMatrix