feat(scanner): Resolve Rush workspace projects - #115
Merged
JordanCoin merged 1 commit intoAug 12, 2026
Conversation
Resolve JS/TS imports from rush.json explicit inventories without invoking Rush. Reject invalid or ambiguous declarations atomically. Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com> Co-Authored-By: GPT-5.6 Sol <codex@openai.com>
This was referenced Aug 9, 2026
JordanCoin
approved these changes
Aug 12, 2026
JordanCoin
left a comment
Owner
There was a problem hiding this comment.
Reviewed the full scanner change and integration path at 777defd. Rush project discovery follows rush.json projectFolder semantics, preserves existing package.json validation, and the focused plus full scanner suites pass. No blocking findings — approved.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolve local JS/TS imports from the explicit project inventory in
rush.json. Invalid, missing, mismatched, unsafe, or duplicate project entries reject the Rush declaration without partial edges.This lets a sandboxed coding agent run
codemap --deps ../rush-worktreeand follow local Rush projects without invoking Node, Rush, or a package manager.Type of change
Checklist
go build && ./codemap .CONTRIBUTING.md; this does not add a new language.Additional notes
Focused verification:
The branch also passes the full macOS race/coverage, vet, Staticcheck, and build checks, plus the Rush-focused Linux Go 1.24 scanner test.
Developed with carefully directed, manually reviewed AI assistance.