Uh oh!
There was an error while loading. Please reload this page.
prevent multiple active applications by a member to an opening - #164
Merged
Conversation
bedeho
reviewed
Feb 26, 2020
| opening_id: CuratorOpeningId<T>, | ||
| member_id: T::MemberId, | ||
| ) -> Result<(), &'static str> { | ||
| for (_id, curator_application) in <CuratorApplicationById<T>>::enumerate() { |
Member
There was a problem hiding this comment.
This iterates all applications on all openings, which is not great, or entirely safe.
At the very least there is CuratorOpening::curator_applications of type BTreeSet<CuratorApplicationId> which allows you to iterate only applications to the given curator opening. This is still not great, but we will do a refactor later where membership binding is done inside subsystem modules, not in membership module, which would make the lookup direct, so this may be the best we can do for now, short of introducing a temporary reverse index.
MemberAuthor
There was a problem hiding this comment.
Updated to iterate only over curator opening applications 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#163