Skip to content

Add tests and make them pass on v0.4 - v0.6 - #16

Closed
jgoldfar wants to merge 7 commits into
JuliaDatabases:masterfrom
jgoldfar:get-tests-passing-v0.4-v0.6
Closed

Add tests and make them pass on v0.4 - v0.6#16
jgoldfar wants to merge 7 commits into
JuliaDatabases:masterfrom
jgoldfar:get-tests-passing-v0.4-v0.6

Conversation

@jgoldfar

Copy link
Copy Markdown

No description provided.

@jgoldfar

Copy link
Copy Markdown
Author

Oops... May replace #15, #12, #11

@jgoldfar

Copy link
Copy Markdown
Author

@iamed2

Copy link
Copy Markdown
Contributor

I would 1) drop 0.4 and 2) put more specific version bounds on DataFrames and DataArrays (I'm suspicious that many versions will fail here).

@jgoldfar

Copy link
Copy Markdown
Author

I'm not sure how to test specific version compatibility of the package with others. Is there a standard way to do it other than pinning a version locally and checking that the package loads?

@iamed2

Copy link
Copy Markdown
Contributor

It's either that or look through the code

@jgoldfar

jgoldfar commented Jul 27, 2017

Copy link
Copy Markdown
Author

Just updated this branch removing v0.4 support as well as the dependence on DataFrames and DataArrays, which were not explicitly used anywhere. Maybe they were meant to be? Travis (https://travis-ci.org/jgoldfar/DBI.jl/builds/258300798) reports all good without them...

@jgoldfar

jgoldfar commented Jul 29, 2017

Copy link
Copy Markdown
Author

Thanks to @amgad-naiem for helping remove the remaining depwarns on v0.6 and schooling me a bit on git/github. Anything remaining to do here?

@quinnjquinnj closed this Dec 19, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jgoldfar@iamed2@quinnj@amgad-naiem