Uh oh!
There was an error while loading. Please reload this page.
WIP: add whitespace check - #463
Draft
simeonschaub wants to merge 1 commit into
Draft
Conversation
simeonschaubforce-pushed
the
sds/whitespace-check
branch
2 times, most recently
from
September 21, 2021 21:44
143b059 to
066711eCompareCodecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #463 +/- ##
=======================================
Coverage 92.98% 92.98% =======================================
Files 14 14 Lines 812 812 =======================================
Hits 755 755 Misses 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oxinabox
commented
Sep 21, 2021
Member
Rather than a check which can fail, can we use the reviewdog action to insert a review suggestion for how to fix? |
simeonschaub
commented
Sep 21, 2021
MemberAuthor
I'll look into that, once I figured out the other issues. |
simeonschaubforce-pushed
the
sds/whitespace-check
branch
from
September 21, 2021 22:03
066711e to
6cbe567Comparest--
commented
Oct 6, 2021
Contributor
@simeonschaub: in case you hadn't spotted it in the related issue yet, #462 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.