Uh oh!
There was an error while loading. Please reload this page.
Fearless taylor version - #109
Conversation
Keno
left a comment
There was a problem hiding this comment.
This is unsound as is, even if you want to make the assumption that taylor-ness is preserved. This just makes everything taylor which is unconditionally unsound.
in that case we definitely need test cases that break the assumption that everything is taylor because locally all the tests pass with this PR. (also, can you decipher the error message on CI I'm not able to understand or reproduce it). |
7da6082 to
9b56edeCompareCodecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## main #109 +/- ##
==========================================
+ Coverage 50.50% 50.77% +0.26%
==========================================
Files 27 27 Lines 2651 2572 -79 ==========================================
- Hits 1339 1306 -33 + Misses 1312 1266 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
If we're willing to use the information that derivatives are linear operators, we can remove a lot of complexity from forward mode differentiation (and improve type stability in the process). I know @Keno doesn't believe this is valid to assume, but IMO the simplification enabled provides a pretty strong justification that this is the right approach.