Skip to content

Fearless taylor version - #109

Open
oscardssmith wants to merge 3 commits into
mainfrom
fearless-taylor-version
Open

Fearless taylor version#109
oscardssmith wants to merge 3 commits into
mainfrom
fearless-taylor-version

Conversation

@oscardssmith

Copy link
Copy Markdown
Member

If we're willing to use the information that derivatives are linear operators, we can remove a lot of complexity from forward mode differentiation (and improve type stability in the process). I know @Keno doesn't believe this is valid to assume, but IMO the simplification enabled provides a pretty strong justification that this is the right approach.

@KenoKeno left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unsound as is, even if you want to make the assumption that taylor-ness is preserved. This just makes everything taylor which is unconditionally unsound.

@oscardssmith

oscardssmith commented Feb 11, 2023

Copy link
Copy Markdown
MemberAuthor

in that case we definitely need test cases that break the assumption that everything is taylor because locally all the tests pass with this PR. (also, can you decipher the error message on CI I'm not able to understand or reproduce it).

@codecov-commenter

codecov-commenter commented Feb 14, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.90323% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.77%. Comparing base (5b3a846) to head (9b56ede).
⚠️ Report is 336 commits behind head on main.

Files with missing linesPatch %Lines
src/jet.jl46.66%8 Missing ⚠️
src/stage1/mixed.jl0.00%4 Missing ⚠️
src/tangent.jl55.55%4 Missing ⚠️
src/extra_rules.jl60.00%2 Missing ⚠️
src/stage1/forward.jl71.42%2 Missing ⚠️
src/interface.jl80.00%1 Missing ⚠️
src/stage1/generated.jl93.75%1 Missing ⚠️
src/stage1/recurse_fwd.jl0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #109 +/- ##
==========================================
+ Coverage 50.50% 50.77% +0.26% 
==========================================
Files 27 27 Lines 2651 2572 -79 ==========================================
- Hits 1339 1306 -33 + Misses 1312 1266 -46 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@oscardssmith@codecov-commenter@Keno