Skip to content

Handle tuples with types in them - #236

Open
oxinabox wants to merge 2 commits into
mainfrom
ox/typeotype
Open

Handle tuples with types in them#236
oxinabox wants to merge 2 commits into
mainfrom
ox/typeotype

Conversation

@oxinabox

Copy link
Copy Markdown
Member

Diffractor was having a bit of a sad because (Int,) has type Tuple{DataType}
but the primal B has type Tuple{Type{Int}},
and while they are logically the same apparently dispatch does not like that.

The solution right now in this PR is to throw away that extra info we have about B and normalize it to just Typle{DataType}.
idk if it is best, I am open to other ideas.

@oxinabox
oxinabox requested a review from KenoOctober 17, 2023 08:18
@codecov

codecovBot commented Oct 17, 2023

Copy link
Copy Markdown

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7be0a92) 56.17% compared to head (2a9a3f7) 56.19%.

Additional details and impacted files
@@ Coverage Diff @@## main #236 +/- ##
==========================================
+ Coverage 56.17% 56.19% +0.01% 
==========================================
Files 28 28 Lines 2848 2849 +1 ==========================================
+ Hits 1600 1601 +1 
Misses 1248 1248 
FilesCoverage Δ
src/stage1/recurse_fwd.jl94.91% <100.00%> (+0.08%)⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox

Copy link
Copy Markdown
MemberAuthor

@Keno could you give this a review, and see if you think of a better way?

@oxinaboxoxinabox mentioned this pull request Dec 29, 2023
3 tasks
@staticfloat

Copy link
Copy Markdown
Collaborator

@Keno review please

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@oxinabox@staticfloat