Skip to content

Use broadcast expressions instead of some loops. - #351

Merged
jrevels merged 2 commits into
JuliaDiff:masterfrom
maleadt:tb/broadcast
Aug 27, 2018
Merged

Use broadcast expressions instead of some loops.#351
jrevels merged 2 commits into
JuliaDiff:masterfrom
maleadt:tb/broadcast

Conversation

@maleadt

Copy link
Copy Markdown
Contributor

Makes this code CuArray-compatible.

Otherwise we always return an Array, where a Tuple would have sufficed
(eg. when indexing with ranges).
@maleadt

Copy link
Copy Markdown
ContributorAuthor

AppVeyor failure seems to occur on (some) master commits as well.

@jrevels

Copy link
Copy Markdown
Member

AppVeyor failure seems to occur on (some) master commits as well.

Yeah, the approximation test tolerances seem to be too tight for AppVeyor a lot of the time...not sure what's going on there.

Thanks for this though!

@jrevels
jrevels merged commit d8a30bf into JuliaDiff:masterAug 27, 2018
@maleadt
maleadt deleted the tb/broadcast branch August 31, 2018 07:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@maleadt@jrevels