Skip to content

Remove rule for conj - #532

Merged
KristofferC merged 4 commits into
JuliaDiff:masterfrom
mcabbott:conj_rule
Jul 28, 2021
Merged

Remove rule for conj#532
KristofferC merged 4 commits into
JuliaDiff:masterfrom
mcabbott:conj_rule

Conversation

@mcabbott

Copy link
Copy Markdown
Member

Special case now handled by DiffRules.

However, to delete this, I think this needs a high lower bound on DiffRules. Or it needs an if to check whether DiffRules has the rule yet.

Closes#531

@codecov-commenter

codecov-commenter commented Jul 5, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (ea822d2) to head (4c0f4b9).
⚠️ Report is 100 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@## master #532 +/- ##
==========================================
+ Coverage 84.72% 84.81% +0.09% 
==========================================
Files 9 9 Lines 825 830 +5 ==========================================
+ Hits 699 704 +5 
Misses 126 126 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcabbottmcabbott mentioned this pull request Jul 15, 2021
@KristofferC
KristofferC marked this pull request as ready for review July 28, 2021 09:29
@KristofferC
KristofferC merged commit 27e1a8d into JuliaDiff:masterJul 28, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

method conj overwritten in dual.jl

3 participants

@mcabbott@codecov-commenter@KristofferC