Uh oh!
There was an error while loading. Please reload this page.
fix float(::Dual) and add float(::Type{<:Dual}) - #535
Conversation
Codecov Report
@@ Coverage Diff @@## master #535 +/- ##
==========================================
+ Coverage 84.83% 84.93% +0.10%
==========================================
Files 9 9 Lines 831 830 -1 ==========================================
Hits 705 705 + Misses 126 125 -1
Continue to review full report at Codecov.
|
The makes no sense to me. I actually got a similar error at some point locally, and then it mysteriously disappeared when I re-ran the test — makes me think it is a bug in Julia itself. Have you seen similar errors prior to this PR? |
KristofferC
commented
Jul 17, 2021
I think I recall seeing something similar to that. It clearly isn't related to the PR. |
Re Reading the stacktrace more carefully, the error is within Note also that I think #530 needs to be merged before tagging anything. |
stevengj
commented
Jul 22, 2021
Is this mergeable, then? If not, what needs to be done? |
dlfivefifty
commented
Jul 26, 2021
We also need |
Fixes#492, fixes#362, closes#419.
The
Base.floatfunction in base supports numeric types, not just values:and by exploiting this we obtain floating-point promotion consistent with
Base.