Uh oh!
There was an error while loading. Please reload this page.
Remove explicit != methods for Dual - #793
Merged
Merged
Conversation
These are already defined by Base in terms of `==`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #793 +/- ##
=======================================
Coverage 90.75% 90.75% =======================================
Files 11 11 Lines 1071 1071 =======================================
Hits 972 972 Misses 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JamesWrigley
commented
Jan 28, 2026
ContributorAuthor
|
devmotion
left a comment
Member
There was a problem hiding this comment.
Thanks, seems like a good change, cf https://github.com/JuliaLang/julia/blob/f726949136712f84e8ecfea7429d23e626683c80/base/operators.jl#L308
Can you update the version number?
JamesWrigley
commented
Jan 28, 2026
ContributorAuthor
Sure, done in b50f9a7. |
devmotion
approved these changes
Jan 28, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are already defined by Base in terms of
==.Fixes these invalidations seen when loading CurveFit.jl (CC @ChrisRackauckas):
Would it be possible to make a new release with this?