Skip to content

Add charts for colordiff to docs and Use docstrings for metrics - #409

Merged
kimikage merged 1 commit into
JuliaGraphics:masterfrom
kimikage:docs_colordiff
Mar 8, 2020
Merged

kimikage merged 1 commit into
JuliaGraphics:masterfrom
kimikage:docs_colordiff

Conversation

@kimikage

@kimikage kimikage commented Mar 3, 2020

Copy link
Copy Markdown
Collaborator

This update the docs for color differences (cf. #398 (comment)).

I changed the example for colordiff, i.e. removed the strange parse.

I also add a doctest for the difference between an HSV color and an HSL color. It may help check the PR #407. The PR #407 is ready for merging, but there may be room for improvement on the fma/muladd (cf. #407 (comment)). So, it is another reasonable option to merge this PR first. (Edit: Either is fine now.)
PR #407 was merged.

@kimikage kimikage mentioned this pull request Mar 3, 2020
28 tasks
@codecov

codecov Bot commented Mar 3, 2020

Copy link
Copy Markdown

Codecov Report

Merging #409 into master will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   80.58%   80.96%   +0.38%     
==========================================
  Files          11       11              
  Lines         896      893       -3     
==========================================
+ Hits          722      723       +1     
+ Misses        174      170       -4     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bf4ed7...96d8590. Read the comment docs.

@kimikage

kimikage commented Mar 8, 2020

Copy link
Copy Markdown
Collaborator Author

The changes of the constructors in this PR do not substantially break the functionality. Corrections and improvements of the docs are always welcome.

@kimikage
kimikage merged commit 2967ec5 into JuliaGraphics:master Mar 8, 2020
@kimikage
kimikage deleted the docs_colordiff branch March 8, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant