CompatHelper: bump compat for FixedPointNumbers to 0.9, (keep existing compat) - #578
github-actions[bot] wants to merge 1 commit into
Conversation
5c6c42d to
bcc38b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 96.75% 95.91% -0.85%
==========================================
Files 9 9
Lines 1296 1225 -71
==========================================
- Hits 1254 1175 -79
- Misses 42 50 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@cormullion could you please take a look into this? It is hold a couple of updates downstream. I can access the Action settings in Colorfy.jl but not in Colors.jl |
I can’t test this at the moment. |
|
@cormullion it might suffice to restart the jobs on GitHub. If you are near a machine with GitHub login, that could be an option. |
|
Could someone with write access please help with this update? |
|
I think ColorTypes.jl needs some attention first. I don’t think I’m knowledgeable enough to start merging loads of pull requests in this area, so I’ll pass… |
|
A heads-up before merging: FixedPointNumbers 0.9 is a breaking release, and CompatHelper does not run the tests against the new compat entry. Two behavioral changes are the most likely to affect this package:
Also worth knowing: Full notes: https://github.com/JuliaMath/FixedPointNumbers.jl/releases/tag/v0.9.0 Note that ColorTypes needs the equivalent bump (JuliaGraphics/ColorTypes.jl#330) before this one can resolve with 0.9 anyway, since ColorTypes also pins FixedPointNumbers to 0.8. |
This pull request changes the compat entry for the
FixedPointNumberspackage from0.8to0.8, 0.9.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.