Skip to content

remove Requires - #42

Closed
GiggleLiu wants to merge 1 commit into
JuliaGraphs:masterfrom
GiggleLiu:removerequires
Closed

remove Requires#42
GiggleLiu wants to merge 1 commit into
JuliaGraphs:masterfrom
GiggleLiu:removerequires

Conversation

@GiggleLiu

Copy link
Copy Markdown

Remove conditional dependencies.

# GraphIO alone
julia> @time using GraphIO
  1.376940 seconds (3.12 M allocations: 221.025 MiB, 2.51% gc time, 32.49% compilation time)
# Remove Requires and restart
julia> @time using GraphIO
  1.775102 seconds (3.73 M allocations: 253.879 MiB, 2.98% gc time, 44.93% compilation time)

@filchristou

Copy link
Copy Markdown
Contributor

is there any reason why this is not merged ? Is there any other plans for the future design of this package ?

@simonschoelly

Copy link
Copy Markdown
Member

I guess nobody had time yet. In any case, it is something that needs to be discussed anyway, as there was a reason why we added Requires - I can't exactly rembember why, although I was the one who did the changes.

It is also nothing urgent, as no bugs are fixed and no new features are added.

@GiggleLiu

Copy link
Copy Markdown
Author

I guess nobody had time yet. In any case, it is something that needs to be discussed anyway, as there was a reason why we added Requires - I can't exactly rembember why, although I was the one who did the changes.

It is also nothing urgent, as no bugs are fixed and no new features are added.

I fix it because there are a lot bugs, I just can not load graph6 module.
And keno find the similar bug. Well, I forgot to mention those bugs in the pr.

@gdalle
gdalle marked this pull request as draft June 23, 2023 08:28
@gdalle

gdalle commented Jun 23, 2023

Copy link
Copy Markdown
Member

This should probably be done with extensions now

@filchristou

Copy link
Copy Markdown
Contributor

yes, can we close this ?

@GiggleLiu GiggleLiu closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants