Skip to content

typo in shell_layout example - #123

Merged
simonschoelly merged 1 commit into
JuliaGraphs:masterfrom
jarlebring:master
Sep 22, 2020
Merged

typo in shell_layout example#123
simonschoelly merged 1 commit into
JuliaGraphs:masterfrom
jarlebring:master

Conversation

@jarlebring

@jarlebringjarlebring commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

The example in the main page has a type problem:

julia> nlist =Vector{Vector{Int}}(undef, 2) julia> nlist[1] = [1:5]
ERROR: MethodError: Cannot `convert` an object of type UnitRange{Int64} to an object of type Int64
Closest candidates are:convert(::Type{T}, ::T) where T<:Number at number.jl:6convert(::Type{T}, ::Number) where T<:Number at number.jl:7convert(::Type{T}, ::Ptr) where T<:Integer at pointer.jl:23...

The brackets should be removed.

@codecov

codecovBot commented Sep 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #123 +/- ##
=======================================
Coverage 33.20% 33.20% =======================================
Files 9 9 Lines 524 524 =======================================
Hits 174 174 Misses 350 350 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f075b1...88388f8. Read the comment docs.

@jarlebring

jarlebring commented Sep 18, 2020

Copy link
Copy Markdown
ContributorAuthor

I did not change the code, so I think the CI error is not due to changes. If you really want it to pass CI, someone with write access to travis can try to let the test run it again.

@simonschoelly

Copy link
Copy Markdown
Member

Thank you, and don't worry about the failing test - this might be some flaky test or some issues with Julia 1.5 on macOS, but should of course not be related to your changes.

@simonschoelly
simonschoelly merged commit ce94183 into JuliaGraphs:masterSep 22, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jarlebring@simonschoelly