Skip to content

Improve documentation; fix gplothtml; add TagBot - #174

Merged
etiennedeg merged 7 commits into
JuliaGraphs:masterfrom
hdavid16:master
Jul 26, 2022
Merged

Improve documentation; fix gplothtml; add TagBot#174
etiennedeg merged 7 commits into
JuliaGraphs:masterfrom
hdavid16:master

Conversation

@hdavid16

@hdavid16hdavid16 commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

-distinguish between args, kwargs
-add missing kwargs
-fix bug in gplothtml
-enable gplothtml to accept same input as gplot
-add TagBot workflow

-distinguish args, kwargs
-add missing kwargs
clarify that Cairo is required to visualize in vscode
Checking for System OS was outdated
@hdavid16hdavid16 changed the title Improve Readme and gplot docstringImprove documentation and fix bug in gplothtmlJul 21, 2022
-allow gplothtml to accept same arguments as gplot
-allow x/y-locs to be of different type (<: Real)
@hdavid16hdavid16 changed the title Improve documentation and fix bug in gplothtmlImprove documentation; fix gplothtml; add TagBotJul 26, 2022
@codecov

codecovBot commented Jul 26, 2022

Copy link
Copy Markdown

Codecov Report

Merging #174 (222fb26) into master (9e0d037) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@ Coverage Diff @@## master #174 +/- ##
==========================================
- Coverage 33.11% 32.92% -0.20% 
==========================================
Files 9 9 Lines 456 565 +109 ==========================================
+ Hits 151 186 +35 - Misses 305 379 +74 
Impacted FilesCoverage Δ
src/plot.jl62.63% <0.00%> (-1.00%)⬇️
src/shape.jl0.00% <0.00%> (ø)
src/stress.jl0.00% <0.00%> (ø)
src/pienode.jl0.00% <0.00%> (ø)
src/deprecations.jl0.00% <0.00%> (ø)
src/collapse_plot.jl0.00% <0.00%> (ø)
src/lines.jl52.22% <0.00%> (+0.19%)⬆️
src/layout.jl48.42% <0.00%> (+1.58%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@etiennedeg

Copy link
Copy Markdown
Member

I think this should not be controversial, so I merge

@etiennedeg
etiennedeg merged commit 52f4aae into JuliaGraphs:masterJul 26, 2022
@hdavid16

Copy link
Copy Markdown
ContributorAuthor

Thanks @etiennedeg. Next time we get a patch release registered with JuliaRegistrator, we'll hopefully get the repo version updated

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hdavid16@etiennedeg