Skip to content

Fix error in shell_layout (included in PR #186) - #181

Closed
hdavid16 wants to merge 1 commit into
JuliaGraphs:masterfrom
hdavid16:fix_shell_layout
Closed

Fix error in shell_layout (included in PR #186)#181
hdavid16 wants to merge 1 commit into
JuliaGraphs:masterfrom
hdavid16:fix_shell_layout

Conversation

@hdavid16

@hdavid16hdavid16 commented Jul 27, 2022

Copy link
Copy Markdown
Contributor

shell layout assumed that the nlist had nodes in increaseing order. However, it should support lists with non-continuous vertices. This is now supported.

Fix#149

@codecov

codecovBot commented Jul 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #181 (4c1f900) into master (52f4aae) will not change coverage.
The diff coverage is 0.00%.

@@ Coverage Diff @@## master #181 +/- ##
=======================================
Coverage 32.92% 32.92% =======================================
Files 9 9 Lines 565 565 =======================================
Hits 186 186 Misses 379 379 
Impacted FilesCoverage Δ
src/layout.jl48.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hdavid16hdavid16 changed the title fixed #149Fix error in shell_layoutAug 2, 2022
@hdavid16hdavid16 mentioned this pull request Aug 5, 2022
@hdavid16hdavid16 changed the title Fix error in shell_layoutFix error in shell_layout (included in PR #186)Aug 5, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect location order returned by shell_layout

1 participant

@hdavid16