Update reduction machinery for 0.7 - #100
Merged
Merged
Conversation
The promotion machinery for reduction in sum/prod was changed in JuliaLang/julia#25051. This updates the use.
This was referenced Jan 17, 2018
andreasnoack
force-pushed
the
sb/promote
branch
from
January 31, 2018 20:00
f9c9e51 to
99e5409
Compare
ararslan
reviewed
Jan 31, 2018
|
|
||
| @test isempty(detect_ambiguities(FixedPointNumbers, Base, Core)) | ||
| if VERSION < v"0.7.0-" | ||
| @test isempty(detect_ambiguities(FixedPointNumbers, Base, Core)) |
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
- Coverage 93.33% 91.44% -1.89%
==========================================
Files 4 4
Lines 180 187 +7
==========================================
+ Hits 168 171 +3
- Misses 12 16 +4
Continue to review full report at Codecov.
|
andreasnoack
force-pushed
the
sb/promote
branch
from
January 31, 2018 20:25
99e5409 to
539ab20
Compare
Member
|
I've defined a few methods to resolve some ambiguities |
andreasnoack
force-pushed
the
sb/promote
branch
from
January 31, 2018 21:51
539ab20 to
f0c718b
Compare
Member
|
Thanks folks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The promotion machinery for reduction in sum/prod was changed in JuliaLang/julia#25051. This updates the use.