Skip to content

Reduce invalidations of other methods - #180

Merged
timholy merged 1 commit into
masterfrom
teh/invalidations
Jun 15, 2020
Merged

Reduce invalidations of other methods#180
timholy merged 1 commit into
masterfrom
teh/invalidations

Conversation

@timholy

@timholy timholy commented May 4, 2020

Copy link
Copy Markdown
Member

These changes, combined with more extensive changes to Julia itself, greatly reduce latency stemming from loading FixedPointNumbers. Ref JuliaLang/julia#35733.

There will be very little benefit to this on its own, but we can at least find out if it works across Julia versions.

These changes, combined with more extensive changes to Julia itself,
greatly reduce latency stemming from loading FixedPointNumbers.
Ref JuliaLang/julia#35733.

There will be very little benefit to this on its own, but we can at
least find out if it works across Julia versions.
@kimikage

kimikage commented May 4, 2020

Copy link
Copy Markdown
Collaborator
julia> sizeof(Fixed{BigInt,10})
8

😝
This is off-topic but it doesn't seem to be well documented what sizeof should return. (https://docs.julialang.org/en/v1.4/base/base/#Base.sizeof-Tuple{Type})
I saw some troubles in the Discourse.

@kimikage

kimikage commented May 4, 2020

Copy link
Copy Markdown
Collaborator

zero, oneunit, one, typemin, typemax, floatmin, floatmax, eps, sizeof, reinterpret,

We will not need sizeof, anymore.

@timholy

timholy commented May 4, 2020

Copy link
Copy Markdown
Member Author

Oof. That's not good. I'm surprised that Core.sizeof does that.

NVM. The result is pretty much undefined when it's not inline storage. In a sense the new answer is better.

@timholy
timholy merged commit 989cca4 into master Jun 15, 2020
@timholy
timholy deleted the teh/invalidations branch June 15, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants