Skip to content

WIP: 0.6 compatibility - #64

Merged
vchuravy merged 1 commit into
masterfrom
vc/0.6
Jan 30, 2017
Merged

vchuravy merged 1 commit into
masterfrom
vc/0.6

Conversation

@vchuravy

Copy link
Copy Markdown
Collaborator

Untested on 0.5 and needs some cleanup probably

The where syntax doesn't work on v0.6.

this rebases #62 on top of #63

@yuyichao

Copy link
Copy Markdown
Contributor

Ah, forgot about this one.....

The changes that should be included from #66 are

All other changes are probably included here already.

@vchuravy
vchuravy changed the base branch from vc/rename to master January 29, 2017 03:27
@vchuravy

Copy link
Copy Markdown
Collaborator Author

Locally the tests passed on v0.5 and v0.6. Should we squash these commits, but that would mean losing authorship attribution @Keno, @yuyichao

@yuyichao

Copy link
Copy Markdown
Contributor

You can do whatever you want with my commit. I'll also close my PR now that you've cherry picked the change...

@codecov-io

codecov-io commented Jan 29, 2017

Copy link
Copy Markdown

Current coverage is 82.96% (diff: 71.42%)

No coverage report found for master at ac602bb.

Powered by Codecov. Last update ac602bb...f76ef21

This disables ambiguity testing on v0.6.
@vchuravy

Copy link
Copy Markdown
Collaborator Author

This is ready to merge from my side.

@vchuravy
vchuravy merged commit 7188a96 into master Jan 30, 2017
@vchuravy
vchuravy deleted the vc/0.6 branch January 30, 2017 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants