Skip to content

correct the rendermode for txt images - #46

Merged
johnnychen94 merged 2 commits into
JuliaTesting:masterfrom
johnnychen94:jc/render
Jan 12, 2020
Merged

correct the rendermode for txt images#46
johnnychen94 merged 2 commits into
JuliaTesting:masterfrom
johnnychen94:jc/render

Conversation

@johnnychen94

@johnnychen94 johnnychen94 commented Jan 11, 2020

Copy link
Copy Markdown
Member

If we call @test_reference "references/camera_new.txt" camera size=(5,10) it would print an "endless" string... It's definitely a bug here.

only BeforeAfterImage mode encodes images into strings
@johnnychen94

johnnychen94 commented Jan 11, 2020

Copy link
Copy Markdown
Member Author

Recent package updates break the test here; it didn't fail on my local machine until I do:

(ReferenceTests) pkg> up
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://gitlab.lflab.cn/julialang/JuliaRegistries/General.git`
 Resolving package versions...
  Updating `~/Documents/Julia/ReferenceTests.jl/Project.toml`
  [5789e2e9] ↑ FileIO v1.0.7 ⇒ v1.2.1
  [a09fc81d] ↑ ImageCore v0.8.5 ⇒ v0.8.10
  [d8c32880] ↑ ImageInTerminal v0.4.0 ⇒ v0.4.2

CI on the latest commit also failed after I retriggered it.

The test I add here actually passes:

Reference file for "camera_new.txt" does not exist.
- NEW CONTENT -----------------
eltype: Gray{Normed{UInt8,8}}
size: (512, 512)
thumbnail:
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀

Update: the cause is narrowed down to FixedPointNumbers v0.7.0, but I need more time to find a solution.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.8%) to 83.077% when pulling 485f02a on johnnychen94:jc/render into eb93dfc on Evizero:master.

1 similar comment
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.8%) to 83.077% when pulling 485f02a on johnnychen94:jc/render into eb93dfc on Evizero:master.

@johnnychen94
johnnychen94 merged commit 9a5ae50 into JuliaTesting:master Jan 12, 2020
@johnnychen94
johnnychen94 deleted the jc/render branch January 12, 2020 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants