Serialize dashboard state read-modify-write with a lock - #3
Open
k0shir0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server threads every request, but the mutating endpoints all do read-state, mutate, write-state with a Codex or network call in the middle - so two overlapping requests can have the slower one silently overwrite the faster one's update. Added an RLock held across the whole cycle in those handlers (reentrant because the agent path writes once mid-command and once at the end), with read_state and write_state also locking themselves so the plain state POST is covered too. Chat doesn't persist anything so it stays unlocked. The trade is that mutations now queue behind a long Codex call, which for a single-user dashboard beats losing an update. Compile-checked and hammered with an 8-thread read-modify-write smoke test locally.