feat: add a way to initialize script dialog from command line - #136
Merged
Merged
Conversation
LeonMatthesKDAB
previously requested changes
Aug 1, 2024
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
Cool change overall, and an important feature 🥳
There's still some loose ends to tidy up before we can merge this though.
|
Oh, also side note: This should be |
smnppKDAB
force-pushed
the
sperret-dataCommandLine
branch
from
August 1, 2024 10:16
dbcbf6b to
5730e87
Compare
LeonMatthesKDAB
left a comment
There was a problem hiding this comment.
Still a few issues left, but looking good otherwise :)
smnppKDAB
force-pushed
the
sperret-dataCommandLine
branch
from
August 2, 2024 15:36
b1cc7a4 to
c115b63
Compare
dfaure-kdab
reviewed
Aug 2, 2024
dfaure-kdab
reviewed
Aug 2, 2024
smnppKDAB
force-pushed
the
sperret-dataCommandLine
branch
3 times, most recently
from
August 2, 2024 16:33
58eb0db to
8929de5
Compare
dfaure-kdab
reviewed
Aug 2, 2024
smnppKDAB
force-pushed
the
sperret-dataCommandLine
branch
from
August 5, 2024 08:15
8929de5 to
28f137e
Compare
dfaure-kdab
approved these changes
Aug 5, 2024
smnppKDAB
added a commit
to smnppKDAB/knut
that referenced
this pull request
Aug 5, 2024
adds the tests corresponding to the PR: KDAB#136
dfaure-kdab
pushed a commit
to smnppKDAB/knut
that referenced
this pull request
Aug 5, 2024
adds the tests corresponding to the PR: KDAB#136
dfaure-kdab
pushed a commit
that referenced
this pull request
Aug 5, 2024
adds the tests corresponding to the PR: #136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Tested in de MR : https://codereview.kdab.com/c/kdab/mfc-utils/+/144788