fix: flush spdlog messages also when logging to stderr - #142
Merged
Merged
Conversation
smnppKDAB
force-pushed
the
sperret-flush_on
branch
from
August 7, 2024 08:59
210cb45 to
5867e8d
Compare
dfaure-kdab
reviewed
Aug 7, 2024
smnppKDAB
force-pushed
the
sperret-flush_on
branch
2 times, most recently
from
August 7, 2024 10:51
e9a098f to
38dbd4d
Compare
smnppKDAB
force-pushed
the
sperret-flush_on
branch
from
August 7, 2024 10:52
38dbd4d to
00daa8f
Compare
The existing code was only enabling flush when logs are redirected to files. Without this, the relative order of the debug output from qWarnings() and from Message.log() wasn't preserved, making debugging difficult.
smnppKDAB
force-pushed
the
sperret-flush_on
branch
from
August 7, 2024 12:20
00daa8f to
7e7f69d
Compare
dfaure-kdab
approved these changes
Aug 7, 2024
spdlog::flush_on(spdlog::level::info)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code was only enabling flush when logs are redirected to files.
Without this, the relative order of the debug output from qWarnings() and from Message.log() wasn't preserved, making debugging difficult.