feat: Add ribbon to the RcViewer - #74
Merged
Merged
Conversation
Member
|
You also need to add a model to And please merge the 2 commits, no need for an individual commit that fixes warnings. |
Montel
force-pushed
the
add_ribbons_support2
branch
from
June 28, 2024 13:06
b681760 to
4cd7d38
Compare
Member
|
Looks good, please amend the second commit, it's not "Fix compile warning" anymore, but "feat: add a ribbon model for rcviewer" |
Montel
force-pushed
the
add_ribbons_support2
branch
from
July 1, 2024 07:33
4cd7d38 to
99762f9
Compare
narnaud
force-pushed
the
add_ribbons_support2
branch
from
July 1, 2024 18:08
99762f9 to
6b71c69
Compare
narnaud
approved these changes
Jul 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed: #73