Uh oh!
There was an error while loading. Please reload this page.
refactor: get rid of session relation - #17
Open
Ad96el wants to merge 5 commits into
Open
Conversation
abdulmth
approved these changes
May 7, 2024
Comment on lines
+44
to
+45
| .map_err(|_| AppError::Challenge("Session not set"))? | ||
| .ok_or(AppError::Challenge("Session not set"))? |
ContributorAuthor
There was a problem hiding this comment.
I get an option after the map_err that's why the ok_or is called. Do you know a smooth way to directly transform it into Result<String, AppError>?
Comment on lines
+31
to
+32
| .map_err(|_| AppError::Challenge("Session not set"))? | ||
| .ok_or(AppError::Challenge("Session not set"))?; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor improvements
Some minor changes. There is no need to store the sessions in the database. Instead, the session data is stored in a session cookie.
Let's hope, it does not break again.